Skip to content

add instruction that TODOs should have an owner - #13260

Closed
ShahakShama wants to merge 1 commit into
shahak/style-guide-Selffrom
shahak/style-guide-named-todos
Closed

ShahakShama wants to merge 1 commit into
shahak/style-guide-Selffrom
shahak/style-guide-named-todos

Conversation

@ShahakShama

@ShahakShama ShahakShama commented Mar 15, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Low risk: documentation-only change with no runtime or behavioral impact.

Overview
Updates style.md to require that TODO comments include an explicit owner (and to ensure the owner is aware if it’s someone else).

Written by Cursor Bugbot for commit 057c933. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from 3a6c53e to ddf5ae5 Compare March 16, 2026 07:38
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 90ab973 to b5a959d Compare March 16, 2026 07:38

@Stavbe Stavbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).


style.md line 396 at r1 (raw file):

When writing a TODO comment, always add an owner for that TODO inside the comment.
If it's not you, make sure the owner is aware of the TODO

add .

@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from ddf5ae5 to 62f52ce Compare March 26, 2026 07:20
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from b5a959d to 057c933 Compare March 26, 2026 07:20
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from 62f52ce to d7a90a3 Compare April 9, 2026 11:50
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 057c933 to 4dd2674 Compare April 9, 2026 11:50
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from d7a90a3 to da665ef Compare April 9, 2026 12:12
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 4dd2674 to 65bf3a6 Compare April 9, 2026 12:12
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from da665ef to d45d5e3 Compare April 9, 2026 12:15
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 65bf3a6 to 671854b Compare April 9, 2026 12:15
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch 2 times, most recently from fd6a6d0 to 9c54c7a Compare April 15, 2026 05:53
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 9c54c7a to 95f7de9 Compare April 26, 2026 10:57
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from 49008b0 to 2a4f9a7 Compare April 26, 2026 10:57
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-named-todos branch from 95f7de9 to e606e87 Compare April 28, 2026 13:43
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-Self branch from 2a4f9a7 to ad3f0b6 Compare April 28, 2026 13:43
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 29, 2026
@github-actions github-actions Bot closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants