Repository navigation
remove github smell testing section - #13113
Closed
ShahakShama wants to merge 1 commit into
Closed
ShahakShama wants to merge 1 commit into
ShahakShama wants to merge 1 commit into
Conversation
This was referenced Mar 10, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Contributor
Author
This was referenced Mar 10, 2026
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
March 10, 2026 07:40
2af41fc to
1ddf7cd
Compare
ShahakShama
force-pushed
the
shahak/style-guide-misc
branch
from
March 10, 2026 08:17
13adae1 to
be20d56
Compare
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
March 10, 2026 08:17
1ddf7cd to
7edc17b
Compare
This was referenced Mar 10, 2026
This was referenced Mar 15, 2026
Closed
ShahakShama
force-pushed
the
shahak/style-guide-misc
branch
from
March 15, 2026 14:58
be20d56 to
ea2a6dd
Compare
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
March 15, 2026 14:58
7edc17b to
bcc90a4
Compare
This was referenced Mar 15, 2026
ShahakShama
force-pushed
the
shahak/style-guide-misc
branch
from
March 16, 2026 07:38
ea2a6dd to
588d2c0
Compare
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
March 16, 2026 07:38
bcc90a4 to
5168a30
Compare
Stavbe
reviewed
Mar 17, 2026
Stavbe
left a comment
Contributor
There was a problem hiding this comment.
@Stavbe reviewed 1 file.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on ShahakShama).
Stavbe
approved these changes
Mar 17, 2026
Stavbe
left a comment
Contributor
There was a problem hiding this comment.
@Stavbe reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
This was referenced Mar 31, 2026
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
April 9, 2026 11:50
5168a30 to
b60e579
Compare
ShahakShama
force-pushed
the
shahak/style-guide-misc
branch
from
April 13, 2026 10:51
0823a9e to
8cd29e2
Compare
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
April 13, 2026 10:51
b60e579 to
93d13bb
Compare
ShahakShama
force-pushed
the
shahak/style-guide-misc
branch
from
April 28, 2026 13:43
8cd29e2 to
81c279c
Compare
ShahakShama
force-pushed
the
shahak/style-guide-remove-github-smell
branch
from
April 28, 2026 13:43
93d13bb to
20b3569
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: documentation-only change that removes a brief guidance section, with no impact on runtime code or behavior.
Overview
Removes the
Github Smell-Testingsection fromstyle.md, eliminating the recommendation to validate questionable one-liners by searching for similar usage in production crates on GitHub.Written by Cursor Bugbot for commit 5168a30. This will update automatically on new commits. Configure here.