Skip to content

remove github smell testing section - #13113

Closed
ShahakShama wants to merge 1 commit into
shahak/style-guide-miscfrom
shahak/style-guide-remove-github-smell
Closed

ShahakShama wants to merge 1 commit into
shahak/style-guide-miscfrom
shahak/style-guide-remove-github-smell

Conversation

@ShahakShama

@ShahakShama ShahakShama commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Low risk: documentation-only change that removes a brief guidance section, with no impact on runtime code or behavior.

Overview
Removes the Github Smell-Testing section from style.md, eliminating the recommendation to validate questionable one-liners by searching for similar usage in production crates on GitHub.

Written by Cursor Bugbot for commit 5168a30. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

ShahakShama commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor Author

@Stavbe Stavbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 1 file.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on ShahakShama).

@Stavbe Stavbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama
ShahakShama force-pushed the shahak/style-guide-misc branch from 8cd29e2 to 81c279c Compare April 28, 2026 13:43
@ShahakShama
ShahakShama force-pushed the shahak/style-guide-remove-github-smell branch from 93d13bb to 20b3569 Compare April 28, 2026 13:43
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 29, 2026
@github-actions github-actions Bot closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants