Repository navigation
improve casting section - #13146
Closed
ShahakShama wants to merge 1 commit into
Closed
improve casting section#13146ShahakShama wants to merge 1 commit into
ShahakShama wants to merge 1 commit into
Conversation
This was referenced Mar 10, 2026
Closed
Closed
Closed
Closed
Closed
Closed
create misc section, move stuff into it, and order by importance (no erasure of anything yet)
#13112
Closed
Contributor
Author
This was referenced Mar 10, 2026
Closed
ShahakShama
force-pushed
the
shahak/style-guide-combinators-compile
branch
from
March 15, 2026 14:58
e81eb9d to
c20618c
Compare
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
March 15, 2026 14:58
5e753e0 to
3894595
Compare
This was referenced Mar 15, 2026
ShahakShama
force-pushed
the
shahak/style-guide-combinators-compile
branch
from
March 16, 2026 07:38
c20618c to
b90e84a
Compare
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
March 16, 2026 07:38
3894595 to
1221a77
Compare
This was referenced Mar 31, 2026
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
April 9, 2026 11:50
1221a77 to
ceda95f
Compare
ShahakShama
force-pushed
the
shahak/style-guide-combinators-compile
branch
from
April 9, 2026 12:12
8563a47 to
ec9c5ff
Compare
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
2 times, most recently
from
April 9, 2026 12:15
73a5a4c to
bcd920f
Compare
ShahakShama
force-pushed
the
shahak/style-guide-combinators-compile
branch
from
April 13, 2026 10:51
45a0e05 to
c03e963
Compare
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
April 13, 2026 10:51
bcd920f to
87370f6
Compare
ShahakShama
changed the base branch from
shahak/style-guide-combinators-compile
to
graphite-base/13146
April 15, 2026 05:53
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
April 15, 2026 05:53
87370f6 to
cbd73cd
Compare
ShahakShama
force-pushed
the
graphite-base/13146
branch
from
April 15, 2026 05:53
c03e963 to
73c95e7
Compare
ShahakShama
changed the base branch from
graphite-base/13146
to
shahak/style-guide-return-value-split-two-lines
April 15, 2026 05:53
ShahakShama
force-pushed
the
shahak/style-guide-return-value-split-two-lines
branch
from
April 28, 2026 13:43
73c95e7 to
b974ec2
Compare
ShahakShama
force-pushed
the
shahak/style-guide-improve-casting
branch
from
April 28, 2026 13:43
cbd73cd to
95ef492
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk documentation-only change that clarifies when to use
into/fromand adds rationale aboutascast overflow behavior.Overview
Updates the Rust style guide’s Casting section to give clearer guidance on choosing
into/try_intovsfrom/try_frombased on whether the compiler can infer the target type.Also adds a brief rationale explaining why
ascasts are discouraged (silent saturation on overflow/underflow), alongside the existing linter prohibition and example.Written by Cursor Bugbot for commit 1221a77. This will update automatically on new commits. Configure here.