[ShahakShama]

Note

Low Risk
Documentation-only edits that restructure and clarify testing guidelines; no runtime or behavior changes.

Overview
Updates style.md’s Testing section to improve readability and organization.

Clarifies assertion guidance (preferring assert_eq over is_ok, with unwrap() as an alternative) and reorganizes test recommendations into explicit subsections for Integration/Flow tests and Binary tests, including revised guidance on where to place tests and how to test binaries via a lib.rs entrypoint.

^{Written by Cursor Bugbot for commit 299b5b6. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[ShahakShama]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• add comment in return value section to split checking the value and performing action to 2 lines #13144 : 2 dependent PRs (#13145 , #13146 )
• remove bad example in foo_or_else section #13141
• improve the starting paragraphs of testing section #13139 👈 (View in Graphite)
• improve macros section #13137
• remove unnecessary misc sections #13131
• reorder sections (move AI and Testing up) #13118
• remove open issues section #13115
• improve external dependencies section #13114
• remove github smell testing section #13113
• create misc section, move stuff into it, and order by importance (no erasure of anything yet) #13112
• change file layout section #13078
• add section on sleep in tests #13073
• add section on dependency injection #13072
• move expect message to a separate section with more explanation #13071
• add directory layout section #12950
• rename allocations and add &Option<T> #12781
• remove laziness  #11591
• rewrite types section #11588
• more comments  #11587
• more comments  #11586
• more comments  #11585
• more comments  #11584
• arithmetic: remove ditto for other mathematical operations. #11848
• gilad/style-guide

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Stavbe]

@Stavbe made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).

---

style.md line 79 at r1 (raw file):

Use unit tests for short (< 1 sec) and threadsafe tests, otherwise use cargo integration tests:

Put flow tests and integration tests inside `tests/` at the crate root if they don't depend on features of their crate (this constraint is valid until [this cargo issue](https://github.com/rust-lang/cargo/issues/2911#issuecomment-1739880593) or [this cargo bug](https://github.com/rust-lang/cargo/issues/15151) get resolved), otherwise put them in a dedicated integration-test crate for the whole package (mostly relevant for multi-crate packages). Cargo integration test files are not parallelized, and are run in an anonymous crate without `cfg(test)`, which allows the test writer to simulate real UX.

can you explain?

Code quote:

 depend on features of their crate 

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Stavbe).

---

style.md line 79 at r1 (raw file):

Previously, Stavbe wrote…

can you explain?

Is this better?

[Stavbe]

@Stavbe made 3 comments.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on ShahakShama).

---

style.md line 79 at r1 (raw file):

Previously, ShahakShama wrote…

Is this better?

yes, thanks

---

style.md line 77 at r2 (raw file):

### Integration and Flow Tests
Use unit tests for short (< 1 sec) and threadsafe tests, otherwise use cargo integration tests:

Maybe we should explain more about it?

Code quote:

 cargo integration tests:

---

style.md line 89 at r2 (raw file):

### Binary Tests

To test binary crates, add a `lib.rs` and call its main from `main.rs` and from the test.

Where to put the tests?

Code quote:

To test binary crates, add a `lib.rs` and call its main from `main.rs` and from the test.

[ShahakShama]

@ShahakShama made 2 comments.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on Stavbe).

---

style.md line 77 at r2 (raw file):

Previously, Stavbe wrote…

Maybe we should explain more about it?

IMO no need

---

style.md line 89 at r2 (raw file):

Previously, Stavbe wrote…

Where to put the tests?

I don't think we need to specify this

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!