Repository navigation
add section preferring use crate over use super - #13700
Closed
ShahakShama wants to merge 1 commit into
Closed
ShahakShama wants to merge 1 commit into
ShahakShama wants to merge 1 commit into
Conversation
|
This change is |
This was referenced Apr 9, 2026
Contributor
Author
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 9, 2026 15:05
87f8a57 to
4c127a0
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 9, 2026 15:05
997cb38 to
0bfba4f
Compare
Stavbe
approved these changes
Apr 12, 2026
Stavbe
left a comment
Stavbe
left a comment
Contributor
There was a problem hiding this comment.
@Stavbe reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 13, 2026 10:51
4c127a0 to
cf1e8a1
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 13, 2026 10:51
0bfba4f to
a88f49c
Compare
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 15, 2026 05:53
cf1e8a1 to
593db32
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 15, 2026 05:53
a88f49c to
0e7c114
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 26, 2026 10:57
0e7c114 to
d3daf03
Compare
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 26, 2026 10:57
593db32 to
c33de6d
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 26, 2026 11:04
d3daf03 to
f50b3ea
Compare
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 26, 2026 11:04
c33de6d to
2aac98d
Compare
ShahakShama
force-pushed
the
shahak/style-guide-expand-panic-and-unreachable
branch
from
April 28, 2026 13:43
f50b3ea to
c591b15
Compare
ShahakShama
force-pushed
the
shahak/style-guide-crate-vs-super
branch
from
April 28, 2026 13:43
2aac98d to
da6d772
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.