Skip to content

Verify Boolean and NonZeroUsize candidate predicates - #3852

Open
joshlf wants to merge 1 commit into
Gkipiolhcatlfs5igrsox32w4yivfp7k3from
G7q2xz2bs5ln4dfgckfspk2us4dhjperw
Open

joshlf wants to merge 1 commit into
Gkipiolhcatlfs5igrsox32w4yivfp7k3from
G7q2xz2bs5ln4dfgckfspk2us4dhjperw

Conversation

@joshlf

@joshlf joshlf commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Use extracted value predicates in the production TryFromBytes validators
for bool and NonZeroUsize. Keep Boolean candidates as bytes until validation,
so invalid encodings remain expressible in the model.

Prove scalar and pair conversions and a terminating Boolean-slice
validator, including rejected inputs. Reuse the production predicates and
compare the concrete candidates with public conversions, exhaustively for
Boolean bytes and pairs.

Register a narrow, source-bound byte read that preserves bounds failure.
Check its complete interpretation and reject an out-of-range-read mutant.
Reading through the generic Maybe pointer abstraction remains a separate
Rust safety premise.

Agent-authored-by: AI agent acting on joshlf's behalf


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/G7q2xz2bs5ln4dfgckfspk2us4dhjperw && git checkout -b pr-G7q2xz2bs5ln4dfgckfspk2us4dhjperw FETCH_HEAD

Checkout

git fetch origin refs/heads/G7q2xz2bs5ln4dfgckfspk2us4dhjperw && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G7q2xz2bs5ln4dfgckfspk2us4dhjperw && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G7q2xz2bs5ln4dfgckfspk2us4dhjperw

Stacked PRs enabled by GHerrit.

Use extracted value predicates in the production TryFromBytes validators
for bool and NonZeroUsize. Keep Boolean candidates as bytes until validation,
so invalid encodings remain expressible in the model.

Prove scalar and pair conversions and a terminating Boolean-slice
validator, including rejected inputs. Reuse the production predicates and
compare the concrete candidates with public conversions, exhaustively for
Boolean bytes and pairs.

Register a narrow, source-bound byte read that preserves bounds failure.
Check its complete interpretation and reject an out-of-range-read mutant.
Reading through the generic Maybe pointer abstraction remains a separate
Rust safety premise.

gherrit-pr-id: G7q2xz2bs5ln4dfgckfspk2us4dhjperw
Agent-authored-by: AI agent acting on joshlf's behalf
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T02:24:47.234919Z e631dcb PR opened
🔒 Security Review ✅ Completed 2026-10-09T02:26:22.992668Z e631dcb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch from c2aa05d to 94a3ef6 Compare October 10, 2026 00:00
@joshlf
joshlf force-pushed the G7q2xz2bs5ln4dfgckfspk2us4dhjperw branch from e631dcb to 05bc5fb Compare October 10, 2026 00:00
@joshlf joshlf changed the title Prove scalar bit-validity predicates and checked byte candidates Verify Boolean and NonZeroUsize candidate predicates Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant