Skip to content

Prove CastUnsized's production layout acceptance gate - #3841

Open
joshlf wants to merge 1 commit into
Gytt7syk4w4f52xlmszabgwlaiofsu7p6from
Gciywztxwi6xppau3ds7fviwyaeqk33fj
Open

joshlf wants to merge 1 commit into
Gytt7syk4w4f52xlmszabgwlaiofsu7p6from
Gciywztxwi6xppau3ds7fviwyaeqk33fj

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Move the numerical decision used by CastUnsized's associated constant into
an extracted helper. Preserve sized casts' size-only comparison and require
accepted slice-DST casts to retain alignment, physical tail offset and the
complete size sequence.

Prove that decision and a Rust assertion harness comparing independent
checked sizes, including overflow and zero-sized tails. A rejected DST
comparison need not establish that its size sequences differ. Pointer
construction and validity remain outside these numerical claims.

Agent-authored-by: AI agent acting on joshlf's behalf


Latest Update: v8 — Compare vs v7

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v7 v6 v5 v4 v3 v2 v1 Base
v8 vs v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gciywztxwi6xppau3ds7fviwyaeqk33fj && git checkout -b pr-Gciywztxwi6xppau3ds7fviwyaeqk33fj FETCH_HEAD

Checkout

git fetch origin refs/heads/Gciywztxwi6xppau3ds7fviwyaeqk33fj && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gciywztxwi6xppau3ds7fviwyaeqk33fj && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gciywztxwi6xppau3ds7fviwyaeqk33fj

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:25:21.395836Z 029004d PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:27:41.290859Z 029004d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 11914d0 to 8b0dc59 Compare October 9, 2026 00:08
@joshlf
joshlf force-pushed the Gciywztxwi6xppau3ds7fviwyaeqk33fj branch from 029004d to 867db38 Compare October 9, 2026 00:08
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.43%. Comparing base (8b0dc59) to head (867db38).

Files with missing lines Patch % Lines
zerocopy/src/pointer/mod.rs 0.00% 47 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           Gytt7syk4w4f52xlmszabgwlaiofsu7p6    #3841      +/-   ##
=====================================================================
- Coverage                              54.02%   53.43%   -0.60%     
=====================================================================
  Files                                     27       27              
  Lines                                   4235     4282      +47     
=====================================================================
  Hits                                    2288     2288              
- Misses                                  1947     1994      +47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Move the numerical decision used by CastUnsized's associated constant into
an extracted helper. Preserve sized casts' size-only comparison and require
accepted slice-DST casts to retain alignment, physical tail offset and the
complete size sequence.

Prove that decision and a Rust assertion harness comparing independent
checked sizes, including overflow and zero-sized tails. A rejected DST
comparison need not establish that its size sequences differ. Pointer
construction and validity remain outside these numerical claims.

gherrit-pr-id: Gciywztxwi6xppau3ds7fviwyaeqk33fj
Agent-authored-by: AI agent acting on joshlf's behalf
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 8b0dc59 to 18cc2e3 Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Gciywztxwi6xppau3ds7fviwyaeqk33fj branch from 867db38 to 173f5af Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 18cc2e3 to 945b8c9 Compare October 10, 2026 00:00
@joshlf
joshlf force-pushed the Gciywztxwi6xppau3ds7fviwyaeqk33fj branch from 173f5af to 182376f Compare October 10, 2026 00:00
@joshlf joshlf changed the title Prove the concrete CastUnsized layout gate Prove CastUnsized's production layout acceptance gate Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants