Skip to content

Prove DstLayout padding and field extension - #3838

Open
joshlf wants to merge 1 commit into
Gasqy37pxeoegrksputrmrts2btqezgvhfrom
Ggsdoapsrkoab2sezv6aidvmzy46fo7pu
Open

joshlf wants to merge 1 commit into
Gasqy37pxeoegrksputrmrts2btqezgvhfrom
Ggsdoapsrkoab2sezv6aidvmzy46fo7pu

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Relate the production pad_to_align and extend methods to mathematical
layout operations. Packing limits placement alignment while retaining the
field's complete size, including its internal padding.

Use mathematical clauses for the operation specs and prove that they
retain the independent guarantees about alignment, normalized payload,
physical fields and padding flags. Keep representation and fit conditions
explicit.

Add total Rust harnesses comparing every stored field and both padding
branches with independent remainder-based checked arithmetic. The resulting
proofs establish the conditional layout behavior without requiring review
of intermediate Lean proof steps.

Agent-authored-by: AI agent acting on joshlf's behalf


Latest Update: v8 — Compare vs v7

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v7 v6 v5 v4 v3 v2 v1 Base
v8 vs v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git checkout -b pr-Ggsdoapsrkoab2sezv6aidvmzy46fo7pu FETCH_HEAD

Checkout

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:26:02.002770Z 3401b31 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:26:01.950965Z 3401b31 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 8, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 119 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (6112ae4) to head (3401b31).

Files with missing lines Patch % Lines
zerocopy/src/layout/composition_checks.rs 0.00% 119 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           Gasqy37pxeoegrksputrmrts2btqezgvh    #3838      +/-   ##
=====================================================================
- Coverage                              57.89%   56.09%   -1.80%     
=====================================================================
  Files                                     24       25       +1     
  Lines                                   3947     4066     +119     
=====================================================================
- Hits                                    2285     2281       -4     
- Misses                                  1662     1785     +123     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Relate the production pad_to_align and extend methods to mathematical
layout operations. Packing limits placement alignment while retaining the
field's complete size, including its internal padding.

Use mathematical clauses for the operation specs and prove that they
retain the independent guarantees about alignment, normalized payload,
physical fields and padding flags. Keep representation and fit conditions
explicit.

Add total Rust harnesses comparing every stored field and both padding
branches with independent remainder-based checked arithmetic. The resulting
proofs establish the conditional layout behavior without requiring review
of intermediate Lean proof steps.

gherrit-pr-id: Ggsdoapsrkoab2sezv6aidvmzy46fo7pu
Agent-authored-by: AI agent acting on joshlf's behalf
@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from 03aba1b to ec7980d Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from 5702f26 to a0346a0 Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from a0346a0 to 58ebaf2 Compare October 10, 2026 00:00
@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from ec7980d to 5284f11 Compare October 10, 2026 00:00
@joshlf joshlf changed the title Prove normalized layout padding and field extension Prove DstLayout padding and field extension Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants