Repository navigation
Conversation
This was referenced Oct 8, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 8, 2026
joshlf
force-pushed
the
Gtab63hdyxorrg5am3uaygvri4dbs3cs5
branch
from
October 8, 2026 12:14
6d38d88 to
5dec377
Compare
joshlf
force-pushed
the
Ghrpggbfqci57rogpnzh6zckn5odscj6u
branch
from
October 8, 2026 12:14
27bc9ef to
4c7bdd5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Gtab63hdyxorrg5am3uaygvri4dbs3cs5 #3845 +/- ##
====================================================================
Coverage ? 51.06%
====================================================================
Files ? 28
Lines ? 4475
Branches ? 0
====================================================================
Hits ? 2285
Misses ? 2190
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gtab63hdyxorrg5am3uaygvri4dbs3cs5
branch
from
October 9, 2026 00:08
5dec377 to
c01180d
Compare
joshlf
force-pushed
the
Ghrpggbfqci57rogpnzh6zckn5odscj6u
branch
from
October 9, 2026 00:08
4c7bdd5 to
984c90f
Compare
This was referenced Oct 9, 2026
Compose plan selection with the actual unchecked metadata conversion. Prove that an accepted plan and a complete source size fitting usize imply that the entire metadata calculation fits and that the destination has the same size. This includes Rust's stronger isize-bounded object-size domain. Add a total Rust assertion harness comparing checked metadata and complete source and destination sizes with the independent remainder-based reference. Metadata overflow after acceptance is an assertion failure, rather than an excluded input. Cover sized-to-sized, sized-to-DST and affine DST-to-DST plans, keeping witness guards explicit. Use that result to shorten the pointer adapter's numerical safety argument. KnownLayout correspondence, reference validity and provenance remain separate obligations. gherrit-pr-id: Ghrpggbfqci57rogpnzh6zckn5odscj6u Agent-authored-by: AI agent acting on joshlf's behalf
joshlf
force-pushed
the
Ghrpggbfqci57rogpnzh6zckn5odscj6u
branch
from
October 9, 2026 02:21
984c90f to
f89ac0d
Compare
joshlf
force-pushed
the
Gtab63hdyxorrg5am3uaygvri4dbs3cs5
branch
from
October 9, 2026 02:21
c01180d to
5a0b5d8
Compare
This was referenced Oct 9, 2026
joshlf
force-pushed
the
Gtab63hdyxorrg5am3uaygvri4dbs3cs5
branch
from
October 10, 2026 00:00
5a0b5d8 to
f27f214
Compare
joshlf
force-pushed
the
Ghrpggbfqci57rogpnzh6zckn5odscj6u
branch
from
October 10, 2026 00:00
f89ac0d to
f5906fb
Compare
joshlf
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose plan selection with the actual unchecked metadata conversion.
Prove that an accepted plan and a complete source size fitting usize imply
that the entire metadata calculation fits and that the destination has the
same size. This includes Rust's stronger isize-bounded object-size domain.
Add a total Rust assertion harness comparing checked metadata and complete
source and destination sizes with the independent remainder-based
reference. Metadata overflow after acceptance is an assertion failure,
rather than an excluded input. Cover sized-to-sized, sized-to-DST and affine
DST-to-DST plans, keeping witness guards explicit.
Use that result to shorten the pointer adapter's numerical safety argument.
KnownLayout correspondence, reference validity and provenance remain
separate obligations.
Agent-authored-by: AI agent acting on joshlf's behalf
Latest Update: v8 — Compare vs v7
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Ghrpggbfqci57rogpnzh6zckn5odscj6u && git checkout -b pr-Ghrpggbfqci57rogpnzh6zckn5odscj6u FETCH_HEADCheckout
git fetch origin refs/heads/Ghrpggbfqci57rogpnzh6zckn5odscj6u && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Ghrpggbfqci57rogpnzh6zckn5odscj6u && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.