Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 8d960d6 | Previous: 6c5624a | Ratio |
|---|---|---|---|
peak memory |
1752.547 MB |
1779.605 MB |
0.98 |
peak threads |
365 threads |
374 threads |
0.98 |
network (transport) |
2726.236 MB |
2736.27 MB |
1.00 |
disk write |
14.324 MB |
1.496 MB |
9.57 |
instructions |
137.723 G |
138.686 G |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
TomCC7
added a commit
that referenced
this pull request
Oct 30, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
October 30, 2026 00:44
2e1fbc6 to
0322960
Compare
TomCC7
added a commit
that referenced
this pull request
Oct 30, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
October 30, 2026 17:26
0322960 to
f0400fc
Compare
TomCC7
added a commit
that referenced
this pull request
Oct 30, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
October 30, 2026 23:55
f0400fc to
f45a957
Compare
TomCC7
added a commit
that referenced
this pull request
Oct 31, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
October 31, 2026 00:32
f45a957 to
4b646db
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
added a commit
that referenced
this pull request
Oct 31, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
October 31, 2026 02:25
4b646db to
40bd5e0
Compare
This was referenced Oct 31, 2026
TomCC7
added a commit
that referenced
this pull request
Nov 2, 2026
Build directly on main with standard connection ports, dedicated control blueprints and the minimal Metal adapter/model configuration. Keep learning and policy changes out of this branch. Reuse model-backed gripper support from #4939 (27d3753) and the Metal driver/configuration from #4900. Lock only the required can-motor-control update to 0.0.11.
TomCC7
added a commit
that referenced
this pull request
Nov 3, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
November 3, 2026 08:03
9d4ae5e to
fdb595c
Compare
TomCC7
added a commit
that referenced
this pull request
Nov 3, 2026
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
November 3, 2026 22:39
fdb595c to
203dd34
Compare
TomCC7
force-pushed
the
cc/feat/metal-learning-integration
branch
from
November 4, 2026 05:23
203dd34 to
8d960d6
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakerMods Metal stations can collect demonstrations and run Dreamlabs EEF policies through the shared learning controls, using one robot model for teleop, planning, policy FK, and execution. This integration includes the Metal implementation and the Dreamlabs backend from #4653; no additional merge of #4865/#4881 is required.
Collection and rollout blueprints cover single Metal with overhead, dual Metal with two wrists, and dual Metal with overhead plus wrists. Live testing confirmed the public dreamlabs/dream-1-beta checkpoint requires all three camera roles; the smaller layouts remain available for collection and compatible custom checkpoints. Metal accepts EEF output only, and Dreamlabs joint output remains restricted to canonical dual YAM. Preview is the default, dispatch is explicit, and Quest grip takeover stops policy without automatic resume.
The shared model now distinguishes the execution grasp_frame (80 mm along gripper_base +Z) from the Dreamlabs protocol dreamlabs_tcp (135 mm along vendor link6 +X, RPY pi/2, 0, pi/2). The protocol frame matches the actual deployed MakerMods playground policy worker. Using grasp_frame directly previously introduced a fixed 20.8 mm and 90-degree discrepancy. Observations use dreamlabs_tcp in each arm's own base frame, and returned protocol poses are transformed back to grasp_frame. Both links are defined in Python, with side prefixes for dual Metal; no separate TCP JSON is required for the standard model. Named or explicit legacy tool-transform overrides remain supported.
Physical Metal arms enable the shared adapter's URDF-based gravity compensation. This stack also includes EEF CBOR RPC serialization, coordinator task-call compatibility fixes, a bounded wait for transient observation skew, the SDK's 15-second cloud request timeout, and detailed trajectory fault reasons. Metal uses a 5 cm final position tolerance. Optional station debugging settings can disable endpoint convergence or observation timing gates; their defaults remain enabled, and hardware limits, finite-value checks, tracking bounds, and deadman supervision remain active.
Validation of the protocol-frame correction: 72 focused regressions and 8 cached-URDF/Pink/mock tests passed, plus scoped mypy and pre-commit. Golden FK vectors were generated offline from the actual deployed playground policy-worker-DxdwLh8C.js, with its URL and SHA256 recorded in the fixture. Tests cover outgoing state and incoming action conversion, single/dual arms, nontrivial base mounts, and existing override compatibility. The deployed worker's FK and the corrected model agree within 1e-7 m in these checks. No new inference or motor commands were issued to validate this correction.
Earlier station testing reached live three-camera inference and hardware EEF execution, and exposed tracking and convergence faults. Sustained task success, physical TCP calibration, measured dual mounting geometry, and real execution after the protocol-frame correction remain unverified. Default dual mounts are a mock example, not measured installation geometry.
This remains an integration draft based on #4653. Station guide: docs/capabilities/manipulation/learning/guides/metal-dreamlabs-setups.md.