Repository navigation
Conversation
Keep existing Damiao adapters, MIT gains, gravity compensation and normalized gripper semantics behind standard connection ports. Add dedicated coordinator blueprints and lifecycle tests without changing existing learning compositions. Reuse model-backed gripper support from PR #4939, commit 27d3753. Based on Metal integration PR #4900 at 40bd5e0.
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 735b9fb | Previous: d2fb73c | Ratio |
|---|---|---|---|
peak memory |
1740.656 MB |
1737.02 MB |
1.00 |
peak threads |
376 threads |
371 threads |
1.01 |
network (transport) |
2725.82 MB |
2733.743 MB |
1.00 |
disk write |
14.285 MB |
1.699 MB |
8.41 |
instructions |
138.097 G |
136.49 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #4960, which is based directly on
mainand excludes the learning stack.Stacked on #4900. Target this integration branch while the learning stack is open; retarget to
mainafter it lands.YAM, OpenArm, and MakerMods Metal currently let the coordinator own their Damiao adapters directly. Add standard connection modules and dedicated
*-connection-controlblueprints so the connection owns CAN, activation, state publication, deadman holds, and shutdown. Follow the connection-module approach in #4958 while retaining the existing adapters, MIT gains, gravity compensation, and normalized gripper openings. Existing blueprints and learning compositions are unchanged.The control models expose logical 0–1 gripper coordinates without changing physical finger geometry. Reuse the model-backed gripper support from #4939 (
27d3753ca1) so coordinator gripper tasks work over connection streams.Validation:
can-motor-control0.0.8 environment, which lacks the required >=0.0.11MotorProfileAPI.Run commands and interface details: Damiao connections.