Repository navigation
chore: upgrade ESLint 8 to 10 with flat config - #563
Merged
Merged
Conversation
Adds lint and format:check npm scripts and a Lint & Type Check job, so the codebase stays clean after the cleanup in #561.
- .eslintrc.cjs -> eslint.config.js (flat config), same rules
- typescript-eslint 8 used directly instead of @vue/eslint-config-typescript,
whose fast-glob -> micromatch -> braces chain has no fixed version
- eslint-plugin-vue 10, vue-eslint-parser 10, eslint-config-prettier 10
- remove unused eslint-plugin-import
- fix new errors: unused catch bindings, and { cause } on rethrown errors
(preserve-caught-error), which needs lib ES2022 in tsconfig
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
📦 Extension Build Ready!Version: 📥 Download Extension (tabee.zip)Installation
Status
🤖 Auto-generated by GitHub Actions |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #562 (uses its
lintscript and CI job). GitHub will retarget this PR tomasteronce #562 is merged.Changes
.eslintrc.cjsreplaced byeslint.config.js(flat config), with the same rule set:eslint:recommended, typescript-eslint recommended,eslint-plugin-vuerecommended, Prettier, and the same custom rules. Dropped@typescript-eslint/interface-name-prefix, which no longer exists.@vue/eslint-config-typescript. That wrapper pullsfast-glob → micromatch → braces, andbraceshas a high-severity advisory with no fixed version.eslint-plugin-vue10,vue-eslint-parser10,eslint-config-prettier10,eslint-plugin-prettier5.5.eslint-plugin-import(unused) and the separate@typescript-eslint/*packages.package-lock.jsonregenerated: npm could not resolve the upgrade from the ESLint 8 tree. Other packages stay within their current major.Code fixes for the new rules (no behaviour change)
catch (e)bindings →catch {}(typescript-eslint 8 checks caught errors).catchnow carry{ cause }(preserve-caught-error, new in ESLint 10). This needslib: ES2022intsconfig.json(types only; Chrome supportsError.causesince v93).Vulnerabilities
npm audit: 15 → 7. The 7 left all come from Tailwind 3 (chokidar,micromatch,braces,postcss-nested), handled in the Tailwind 4 PR.Tested
ESLint, Prettier,
vue-tsc, 226 tests andnpm run buildall pass locally.