Repository navigation
chore: upgrade to Vite 8, Vitest 5, vue-tsc 3 and @crxjs 3 - #564
Merged
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
- vite 8, @vitejs/plugin-vue 6.0.10, @crxjs/vite-plugin 3 - vitest, @vitest/ui, @vitest/coverage-v8 5; jsdom 30 - vue-tsc 3 - vite.config.ts: import attributes 'with' instead of 'assert' - tests: mock document/location/history with vi.stubGlobal, as these window properties are getter-only in the new jsdom environment - RuleForm: remove unused customIconInput template ref (flagged by vue-tsc 3)
sebastienfontaine
force-pushed
the
chore/vite-8
branch
from
October 14, 2026 18:22
22d8b84 to
31547a1
Compare
📦 Extension Build Ready!Version: 📥 Download Extension (tabee.zip)Installation
Status
🤖 Auto-generated by GitHub Actions |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #563. GitHub will retarget it once the PRs below it are merged.
Changes
@vitejs/plugin-vue6.0.10,@crxjs/vite-plugin2 → 3 (ESM only; the project is already ESM).@vitest/uiand@vitest/coverage-v85, jsdom 27 → 30.vite.config.ts:import … with { type: 'json' }instead of the removedassertsyntax.Code changes
document,locationandhistoryare now getter-only on the jsdom window, so assigning them throws. The 3 affected test files (IconService,TitleService,UrlChangeDetector) now usevi.stubGlobal()/vi.unstubAllGlobals().RuleForm.vue: removed thecustomIconInputtemplate ref, which was never read (vue-tsc 3 now flags it).Not included
@types/chrome0.0.268 → 0.3.x was tried and reverted: it typeschrome.storageresults as{}and dropschrome.tabs.TabChangeInfo, which needs typing every storage access. Better as its own PR.Tested
vue-tsc, 226 tests (with coverage) andnpm run buildpass locally.npm run devstarts and generatesdist/with CRXJS.