Skip to content

UrdfManager: URDF self-masking and joint tf - #4612

Merged
mustafab0 merged 18 commits into
mainfrom
jeff/feat/urdf_manager
Oct 26, 2026
Merged

mustafab0 merged 18 commits into
mainfrom
jeff/feat/urdf_manager

Conversation

@jeff-hykin

@jeff-hykin jeff-hykin commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Replace RoboPlanPointCloudSelfFilter with UrdfManager, which can publish the URDF's joint tf, a self-masked point cloud, and the URDF and meshes for front ends to render.

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go2 replay realtime (arm64)

Details
Benchmark suite Current: 7894051 Previous: 6de7182 Ratio
peak memory 1740.68 MB 1692.82 MB 1.03
peak threads 367 threads 373 threads 0.98
network (transport) 2731.995 MB 2728.305 MB 1.00
disk write 1.691 MB 1.688 MB 1.00
instructions 136.224 G 137.493 G 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.15686% with 32 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/robot/urdf_manager_point_clearing.py 84.07% 12 Missing and 6 partials ⚠️
dimos/robot/roboplan_body_filter.py 86.66% 3 Missing and 3 partials ⚠️
dimos/robot/urdf_manager.py 92.85% 5 Missing and 1 partial ⚠️
dimos/robot/assets/model.py 91.30% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
+ Coverage   82.44%   82.46%   +0.01%     
==========================================
  Files        1696     1698       +2     
  Lines      158776   159005     +229     
  Branches    13251    13814     +563     
==========================================
+ Hits       130904   131118     +214     
- Misses      24214    24227      +13     
- Partials     3658     3660       +2     
Components Coverage Δ
Tests 96.85% <100.00%> (+0.01%) ⬆️
Flag Coverage Δ
OS-macos-latest 76.41% <91.91%> (+0.03%) ⬆️
OS-ubuntu-24.04-arm 76.24% <91.66%> (?)
OS-ubuntu-latest 76.59% <91.91%> (+0.02%) ⬆️
Py-3.10 76.59% <91.91%> (+0.74%) ⬆️
Py-3.11 76.58% <91.91%> (+0.02%) ⬆️
Py-3.12 76.59% <91.91%> (+0.03%) ⬆️
SelfHosted-Large 32.13% <35.29%> (-0.01%) ⬇️
SelfHosted-Linux 40.38% <58.82%> (-0.13%) ⬇️
SelfHosted-macOS 40.84% <59.06%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/msgs/files/File.py 100.00% <100.00%> (ø)
dimos/robot/all_blueprints.py 100.00% <ø> (ø)
dimos/robot/galaxea/r1pro/test_joint_tf.py 100.00% <100.00%> (ø)
dimos/robot/manipulators/common/blueprints.py 91.66% <100.00%> (ø)
...s/robot/manipulators/xarm/blueprints/test_grasp.py 100.00% <100.00%> (+7.40%) ⬆️
dimos/robot/test_urdf_manager.py 99.11% <100.00%> (ø)
dimos/robot/assets/model.py 89.49% <91.30%> (+0.10%) ⬆️
dimos/robot/roboplan_body_filter.py 86.66% <86.66%> (ø)
dimos/robot/urdf_manager.py 92.85% <92.85%> (ø)
dimos/robot/urdf_manager_point_clearing.py 84.07% <84.07%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[High impact] Renames and refactors the point cloud self-filter module.

Not safe to merge until mesh requests are processed without silently dropping distinct requested files.

Findings

  1. P1 Mesh requests disappear during bursts ▶

Summary

This PR replaces RoboPlanPointCloudSelfFilter with UrdfManager.

  • UrdfManager publishes model joint transforms from joint states.
  • The xArm map uses UrdfManager to filter robot returns.
  • URDF viewers can fetch meshes by package URI.

Fix the mesh-request delivery failure before merging: clients can remain waiting for files needed to complete the robot view.

Reviews (1) · Last reviewed commit: "UrdfManager: one module poses a URDF fro..." · Reviewed by Greptile

Comment thread dimos/robot/urdf_manager.py Outdated
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Oct 16, 2026
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Oct 18, 2026
@jeff-hykin
jeff-hykin changed the base branch from main to jeff/fix/v4l2_jetson_egl October 19, 2026 15:24
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Oct 19, 2026
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Oct 21, 2026
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Oct 21, 2026
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Oct 21, 2026
…erers ask render_file_request for the URDF (*.urdf) or a file it names by full path, answered on file_info (robot_description, file_request and hashes gone)
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Oct 23, 2026
# Conflicts:
#	dimos/robot/all_blueprints.py
#	dimos/robot/manipulators/xarm/blueprints/grasp.py
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Oct 25, 2026
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Oct 25, 2026
…a plain UrdfManager never imports RoboPlan; tests: one FK seed, keepalive and import-isolation tests dropped
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Oct 25, 2026
Base automatically changed from jeff/fix/v4l2_jetson_egl to main October 26, 2026 20:52

@mustafab0 mustafab0 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to find a better home for the urdf manager and the filter util as well.

@mustafab0
mustafab0 enabled auto-merge (squash) October 26, 2026 20:55
@mustafab0
mustafab0 merged commit cc9666a into main Oct 26, 2026
60 of 62 checks passed
@mustafab0
mustafab0 deleted the jeff/feat/urdf_manager branch October 26, 2026 20:57

This branch was previously deployed

1 inactive deployment
cachix — 78940514 Deployed Oct 25, 2026 by jeff-hykin via cachix-build #14274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants