Repository navigation
UrdfManager: URDF self-masking and joint tf - #4612
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 7894051 | Previous: 6de7182 | Ratio |
|---|---|---|---|
peak memory |
1740.68 MB |
1692.82 MB |
1.03 |
peak threads |
367 threads |
373 threads |
0.98 |
network (transport) |
2731.995 MB |
2728.305 MB |
1.00 |
disk write |
1.691 MB |
1.688 MB |
1.00 |
instructions |
136.224 G |
137.493 G |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #4612 +/- ##
==========================================
+ Coverage 82.44% 82.46% +0.01%
==========================================
Files 1696 1698 +2
Lines 158776 159005 +229
Branches 13251 13814 +563
==========================================
+ Hits 130904 131118 +214
- Misses 24214 24227 +13
- Partials 3658 3660 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[High impact] Renames and refactors the point cloud self-filter module. Not safe to merge until mesh requests are processed without silently dropping distinct requested files. Findings
SummaryThis PR replaces
Fix the mesh-request delivery failure before merging: clients can remain waiting for files needed to complete the robot view. Reviews (1) · Last reviewed commit: "UrdfManager: one module poses a URDF fro..." · Reviewed by Greptile |
…erers ask render_file_request for the URDF (*.urdf) or a file it names by full path, answered on file_info (robot_description, file_request and hashes gone)
# Conflicts: # dimos/robot/all_blueprints.py # dimos/robot/manipulators/xarm/blueprints/grasp.py
…y URI), not files.MeshFile
…ments that restate the code
…a plain UrdfManager never imports RoboPlan; tests: one FK seed, keepalive and import-isolation tests dropped
Replace RoboPlanPointCloudSelfFilter with UrdfManager, which can publish the URDF's joint tf, a self-masked point cloud, and the URDF and meshes for front ends to render.