Repository navigation
feat(imitation): record explicit portable collection profiles - #4396
Conversation
There was a problem hiding this comment.
go2 replay realtime
Details
| Benchmark suite | Current: 6eeb6ba | Previous: 7529659 | Ratio |
|---|---|---|---|
first frame wall |
10.375 s |
11.519 s |
0.90 |
first frame cpu |
22.699 s |
23.908 s |
0.95 |
run cpu |
31.977 s |
33.323 s |
0.96 |
run cpu (user) |
23.843 s |
25.718 s |
0.93 |
run cpu (system) |
8.134 s |
7.604 s |
1.07 |
peak memory |
2715.688 MB |
2705.062 MB |
1.00 |
peak threads |
402 threads |
406 threads |
0.99 |
disk read |
23.309 MB |
35.621 MB |
0.65 |
disk write |
11.324 MB |
11.242 MB |
1.01 |
network (transport) |
2714.407 MB |
2728.796 MB |
0.99 |
network (external rx) |
0.063 MB |
0.059 MB |
1.07 |
network (external tx) |
0.157 MB |
0.147 MB |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #4396 +/- ##
==========================================
- Coverage 83.26% 83.02% -0.25%
==========================================
Files 1743 1748 +5
Lines 168069 168743 +674
Branches 13898 13934 +36
==========================================
+ Hits 139949 140104 +155
- Misses 24449 24974 +525
+ Partials 3671 3665 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'go2 replay realtime'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.08.
| Benchmark suite | Current: 2cde5e4 | Previous: 7529659 | Ratio |
|---|---|---|---|
network (external rx) |
0.103 MB |
0.059 MB |
1.75 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 41bf99b | Previous: c339308 | Ratio |
|---|---|---|---|
peak memory |
1740.633 MB |
1759.73 MB |
0.99 |
peak threads |
378 threads |
370 threads |
1.02 |
network (transport) |
2729.318 MB |
2736.274 MB |
1.00 |
disk write |
1.449 MB |
1.688 MB |
0.86 |
instructions |
137.307 G |
138.156 G |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
92d6fe5 to
ef36c11
Compare
04c93ee to
a3c7472
Compare
c3291ca to
41bf99b
Compare
Problem
Solution
CollectionModule/CollectionModuleConfigand migrate callers. Keep profile-dependent construction behindcollect(profile=...), without a standalone launcher entry.CollectionProfiledeclares data;collect(profile=...)creates only the recorder. Robot Blueprints own producers and episodes.RecordingSchema; conversion combines it with input and output settings. Keep typed inputs inside the recorder.Validation