Repository navigation
feat(imitation): integrate native OpenYAM Quest collection - #4343
Conversation
There was a problem hiding this comment.
go2 replay realtime
Details
| Benchmark suite | Current: aa0ee37 | Previous: 7529659 | Ratio |
|---|---|---|---|
first frame wall |
10.14 s |
11.519 s |
0.88 |
first frame cpu |
21.519 s |
23.908 s |
0.90 |
run cpu |
31.182 s |
33.323 s |
0.94 |
run cpu (user) |
23.335 s |
25.718 s |
0.91 |
run cpu (system) |
7.847 s |
7.604 s |
1.03 |
peak memory |
2705.754 MB |
2705.062 MB |
1.00 |
peak threads |
396 threads |
406 threads |
0.98 |
disk read |
14.699 MB |
35.621 MB |
0.41 |
disk write |
10.977 MB |
11.242 MB |
0.98 |
network (transport) |
2732.809 MB |
2728.796 MB |
1.00 |
network (external rx) |
0.053 MB |
0.059 MB |
0.90 |
network (external tx) |
0.141 MB |
0.147 MB |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'go2 replay realtime'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.08.
| Benchmark suite | Current: 68edf43 | Previous: cdfaef0 | Ratio |
|---|---|---|---|
disk read |
23.203 MB |
20.871 MB |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cc/feat/webcam-capture-config #4343 +/- ##
=================================================================
- Coverage 83.05% 83.03% -0.02%
=================================================================
Files 1748 1750 +2
Lines 168820 168914 +94
Branches 13935 13938 +3
=================================================================
+ Hits 140208 140255 +47
- Misses 24946 24994 +48
+ Partials 3666 3665 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[Medium impact] No outstanding merge-blocking defects were identified; this assessment depends on the control-button and CI fixes in PR #4088. SummaryAdds
T-Rex validation blockedThe native recording roundtrip could not complete because the SQLite library loaded by the recorder lacks Reviews (1) · Last reviewed commit: "refactor(collection): keep episode contr..." · Reviewed by Greptile |
Problem
Solution
collect(profile=...)explicitly with canonical joint order.coordinator_joint_commandand persist the shared recording schema.Validation