Add SnakePlay.reset to restore players and clear items - #2
Open
kvnloo wants to merge 1 commit into
Open
Conversation
summary.md already describes reset behavior; other play modules expose it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary.mdsays SnakePlay owns reset behavior;CombatPlay/FlightPlayalready exposereset(), but SnakePlay did not.addPlayerand restore them inreset(), also clearing items.SnakePlay.test.js.Test plan
node --experimental-default-type=module --test gameblocks/modules/gameplay/SnakePlay.test.jsIndependent verify: parent threw
play.reset is not a function; SHA87c770cdbb95c57c96603272d3ee7a1189bb78d3passesSnakePlay.test.js1/1.