Skip to content

Fix compact restarts for surface_csv - #2892

Merged
bigfooted merged 4 commits into
developfrom
fix_compact_restarts
Sep 13, 2026
Merged

Fix compact restarts for surface_csv #2892
bigfooted merged 4 commits into
developfrom
fix_compact_restarts

Conversation

@bigfooted

Copy link
Copy Markdown
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

continuation of #2891
SURFACE_CSV still has a compact restart issue. Since surface_csv is not a restart file, we do not apply compactness to it.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@joshkellyjak

Copy link
Copy Markdown
Contributor

Perhaps to prevent something like this happening again in future it is best to add some test case with expected output results?

@joshkellyjak joshkellyjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, an output test would be beneficial or update to existing regression perhaps?

@bigfooted

Copy link
Copy Markdown
Contributor Author

@joshkellyjak I added a run -> save ->restart regression test for compact restart.

@bigfooted
bigfooted merged commit 2c34b90 into develop Sep 13, 2026
37 of 38 checks passed
@bigfooted
bigfooted deleted the fix_compact_restarts branch September 13, 2026 12:07
@pcarruscag
pcarruscag restored the fix_compact_restarts branch September 13, 2026 17:57
pcarruscag added a commit that referenced this pull request Sep 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use python to modify the original restart on the fly, as I have done in other tests.
No duplication, means no duplication, everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants