Fix compact restarts for surface_csv - #2892
Merged
Merged
Conversation
Contributor
|
Perhaps to prevent something like this happening again in future it is best to add some test case with expected output results? |
joshkellyjak
requested changes
Sep 11, 2026
joshkellyjak
left a comment
Contributor
There was a problem hiding this comment.
LGTM code-wise, an output test would be beneficial or update to existing regression perhaps?
pcarruscag
approved these changes
Sep 12, 2026
Contributor
Author
|
@joshkellyjak I added a run -> save ->restart regression test for compact restart. |
joshkellyjak
approved these changes
Sep 13, 2026
pcarruscag
reviewed
Sep 13, 2026
Member
There was a problem hiding this comment.
Please use python to modify the original restart on the fly, as I have done in other tests.
No duplication, means no duplication, everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
continuation of #2891
SURFACE_CSV still has a compact restart issue. Since surface_csv is not a restart file, we do not apply compactness to it.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.