Fix ASCII compact restarts - #2891
Merged
Merged
Conversation
pcarruscag
approved these changes
Sep 10, 2026
6 tasks
bigfooted
added a commit
that referenced
this pull request
Sep 13, 2026
## Proposed Changes *Give a brief overview of your contribution here in a few sentences.* continuation of #2891 SURFACE_CSV still has a compact restart issue. Since surface_csv is not a restart file, we do not apply compactness to it. ## Related Work *Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.* ## PR Checklist *Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.* - [x] I am submitting my contribution to the develop branch. - [ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson). - [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/). - [ ] I used the pre-commit hook to prevent dirty commits and used `pre-commit run --all` to format old commits. - [ ] I have added a test case that demonstrates my contribution, if necessary. - [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
CSU2FileWritertakes its header fromdataSorter->GetRequiredFieldNames()but reads data columns by positional index, so the sorter it's handed must be the one whose layout those names describe. TheRESTART_BINARYbranch directly below already does this correctly withvolumeDataSorterCompactbut for ASCII restarts where the user has specifiedVOLUME_OUTPUTfields outside the compact set, the columns become shifted and the outputted values are wrong.Related Work
N/A
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.