fix(chart) :: align stacked series on their X values - #1370
Draft
81reap wants to merge 3 commits into
Draft
Conversation
This was referenced Aug 8, 2026
81reap
marked this pull request as draft
August 8, 2026 23:17
lovasoa
marked this pull request as ready for review
August 10, 2026 15:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lovasoa
marked this pull request as draft
August 10, 2026 15:21
81reap
force-pushed
the
stack/5-chart-stacked
branch
from
August 10, 2026 19:27
68fda3f to
91e6ce6
Compare
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1362
Motivation
xvalue, so a series missing a point is piled on top of the wrong one.xvalues, but only forbarcharts on a text axis.Description
sqlpage/chart_series.jsasalign_series, which gives every series a point at everyxany of them has, and counts a missing one as zero.build.rsa/* !include ./file.js */directive, next to the one it already has for CDN scripts, sochart_series.jsis inlined ahead ofapexcharts.js.tests/js/, run by Node's test runner fromnpm test, since this logic is worth testing without a browser.stackedparameter, and add the stacked area example from stacked area graphs / stacked line graphs #1362.Testing
xvalues.npm testchecks 41 files and reports nothing.no console errors on card pagefails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: