feat(chart) :: render column charts as bar charts - #1369
Merged
Conversation
lovasoa
approved these changes
Aug 10, 2026
81reap
force-pushed
the
stack/4-chart-column
branch
from
August 10, 2026 19:22
066edb0 to
42e7f53
Compare
81reap
force-pushed
the
stack/4-chart-column
branch
from
August 10, 2026 19:55
42e7f53 to
49eb033
Compare
81reap
marked this pull request as ready for review
August 10, 2026 19:56
Contributor
Author
|
CI failure seems to be related to pulling something from docker and not the code changes @lovasoa https://github.com/sqlpage/SQLPage/actions/runs/31426524367/job/93582161234?pr=1369 |
This was referenced Aug 10, 2026
lovasoa
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
columnas a type, but ApexCharts has no such type, so acolumnchart draws nothing.stackedon a type that cannot stack, such asrangeBar, leaves the chart empty as well.Description
build_sqlpage_chart, through an alias table that mapscolumntobar.data.type, so an alias behaves like the type it names everywhere.stackedonly forline,areaandbar, and ignore it elsewhere.columnas a synonym ofbar, and say which types honourstacked.console.logof every chart's options.Testing
columnchart draws vertical bars, and arangeBarchart that asks to be stacked still draws.npm testchecks 38 files and reports nothing.no console errors on card pagefails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: