Skip to content

feat(chart) :: render column charts as bar charts - #1369

Merged
lovasoa merged 1 commit into
sqlpage:mainfrom
81reap:stack/4-chart-column
Aug 11, 2026
Merged

feat(chart) :: render column charts as bar charts#1369
lovasoa merged 1 commit into
sqlpage:mainfrom
81reap:stack/4-chart-column

Conversation

@81reap

@81reap 81reap commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • The chart documentation lists column as a type, but ApexCharts has no such type, so a column chart draws nothing.
  • Asking for stacked on a type that cannot stack, such as rangeBar, leaves the chart empty as well.

Description

  • Resolve the ApexCharts type once, at the top of build_sqlpage_chart, through an alias table that maps column to bar.
  • Read that resolved type in the ten places that used to read data.type, so an alias behaves like the type it names everywhere.
  • Pass stacked only for line, area and bar, and ignore it elsewhere.
  • Document column as a synonym of bar, and say which types honour stacked.
  • Drop a console.log of every chart's options.
  • Add two changelog entries.

Testing

  • The browser suite passes 28 tests, two of them new: a column chart draws vertical bars, and a rangeBar chart that asks to be stacked still draws.
  • npm test checks 38 files and reports nothing.
  • no console errors on card page fails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.

GitHub cannot base a pull request on a branch that lives in a fork, so all eight target main and each one carries the commits of those above it. Review and merge them in order:

  1. fix(biome.js) :: fix remaining lint issues #1366 :: fix(biome.js) :: fix remaining lint issues
  2. fix(modal) :: give modal component an accessible name #1367 :: fix(modal) :: give modal component an accessible name
  3. fix(map) :: ignore map coordinates that are not a pair of numbers #1368 :: fix(map) :: ignore map coordinates that are not a pair of numbers
  4. feat(chart) :: render column charts as bar charts #1369 :: feat(chart) :: render column charts as bar charts ← this PR
  5. fix(chart) :: align stacked series on their X values #1370 :: fix(chart) :: align stacked series on their X values
  6. fix(chart) :: line series up on a category axis for every chart type #1371 :: fix(chart) :: line series up on a category axis for every chart type
  7. fix(npm) :: install dependencies only once at root level #1372 :: fix(npm) :: install dependencies only once at root level
  8. feat(typescript) :: typecheck browser JavaScript in CI #1373 :: feat(typescript) :: typecheck browser JavaScript in CI

@81reap
81reap force-pushed the stack/4-chart-column branch from 066edb0 to 42e7f53 Compare August 10, 2026 19:22
@81reap
81reap force-pushed the stack/4-chart-column branch from 42e7f53 to 49eb033 Compare August 10, 2026 19:55
@81reap
81reap marked this pull request as ready for review August 10, 2026 19:56
@81reap

81reap commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

CI failure seems to be related to pulling something from docker and not the code changes @lovasoa

Run scripts/test-examples-hurl.sh "examples/tiny_twitter"
  scripts/test-examples-hurl.sh "examples/tiny_twitter"
  shell: /usr/bin/bash -e {0}
  env:
    CARGO_TERM_COLOR: always
    HURL_VERSION: 8.0.0
    REGISTRY_USERNAME: lovasoa
    REGISTRY_IMAGE: lovasoa/sqlpage
Testing examples/tiny_twitter
   postgres Pulling 
   postgres Error Get "https://registry-1.docker.io/v2/": context deadline exceeded
  Error response from daemon: Get "https://registry-1.docker.io/v2/": context deadline exceeded
  Error: examples/tiny_twitter failed to start
docker compose ps for examples/tiny_twitter
  NAME      IMAGE     COMMAND   SERVICE   CREATED   STATUS    PORTS
docker compose logs for examples/tiny_twitter

https://github.com/sqlpage/SQLPage/actions/runs/31426524367/job/93582161234?pr=1369

@lovasoa
lovasoa merged commit b8f10ad into sqlpage:main Aug 11, 2026
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants