Repository navigation
Walk parent _dom pointers in a loop inside renderComponent - #5380
Merged
Merged
Conversation
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. duration
usedJSHeapSize
Results⏳ Benchmarks are currently running. Results below are out of date. create10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -16 B (-0.1%) Total Size: 16.2 kB 📦 View Changed
ℹ️ View Unchanged
|
JoviDeCroock
enabled auto-merge
November 18, 2026 09:39
marvinhagemeister
approved these changes
Nov 18, 2026
JoviDeCroock
force-pushed
the
golf/parent-dom-pointers-loop
branch
4 times, most recently
from
November 18, 2026 10:30
b262a38 to
13f57e1
Compare
updateParentDomPointers recursed up the component ancestors and had a single caller. Do the same walk in a loop where it was called.
JoviDeCroock
force-pushed
the
golf/parent-dom-pointers-loop
branch
from
November 18, 2026 10:35
13f57e1 to
d47a41b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateParentDomPointersrecursed up the component ancestors and had a single caller.renderComponentnow does the same walk in a loop.The callback passed to
.some()now closes over a variable ofrenderComponent, so V8 allocates a context on every queued rerender: about 20 bytes more short-lived heap per update in a 10,000forceUpdaterun. I measured no time difference locally on many-updates, todo, update10th1k, filter-list, text-update and replace1k.Saves 15 B gzip in core.
Note
Written with the help of Fable 5.2