Skip to content

Inline renderComponent into the render queue loop - #5383

Merged
JoviDeCroock merged 1 commit into
mainfrom
golf/inline-render-component
Nov 18, 2026
Merged

JoviDeCroock merged 1 commit into
mainfrom
golf/inline-render-component

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

renderComponent() had a single caller. Its body now runs inside process(), behind the same two checks: the component is dirty and still has a _parentDom.

The callback that walks the parent _dom pointers (#5380) now captures a local of process(), which runs once per flush, instead of one of renderComponent(), which ran once per component.

Saves 4 B gzip in core.

Note

Written with the help of Fable 5.2

renderComponent() had a single caller. Its body now runs inside
process(), behind the same two checks (dirty, still has a _parentDom).

The callback that walks the parent _dom pointers now captures a local of
process(), which runs once per flush, instead of one of renderComponent(),
which ran once per component.
@github-actions

Copy link
Copy Markdown

Size Change: -4 B (-0.02%)

Total Size: 16.2 kB

📦 View Changed
Filename Size Change
dist/preact.mjs 4.94 kB -4 B (-0.08%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.97 kB
debug/dist/debug.mjs 4.19 kB
devtools/dist/devtools.mjs 268 B
hooks/dist/hooks.mjs 1.52 kB
jsx-runtime/dist/jsxRuntime.mjs 875 B
test-utils/dist/testUtils.mjs 472 B

compressed-size-action

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: slower ❌ 0% - 2% (0.65ms - 17.79ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +2% (-0.39ms - +0.29ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +4% (-1.29ms - +1.83ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +2% (-0.26ms - +0.36ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +3% (-1.99ms - +1.84ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +9% (-0.04ms - +0.15ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +3% (-0.71ms - +0.70ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +6% (-0.48ms - +1.58ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.00ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +5% (-0.10ms - +0.24ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: faster ✔ 1% - 4% (0.01ms - 0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local766.40ms - 780.77ms-slower ❌
0% - 2%
0.65ms - 17.79ms
preact-main759.69ms - 769.04msfaster ✔
0% - 2%
0.65ms - 17.79ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.24ms - 19.24ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.24ms - 19.24msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.42ms - 16.90ms-unsure 🔍
-2% - +2%
-0.39ms - +0.29ms
preact-main16.47ms - 16.96msunsure 🔍
-2% - +2%
-0.29ms - +0.39ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.58ms-unsure 🔍
-0% - +1%
-0.00ms - +0.02ms
preact-main1.56ms - 1.57msunsure 🔍
-1% - +0%
-0.02ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local50.15ms - 52.32ms-unsure 🔍
-3% - +4%
-1.29ms - +1.83ms
preact-main49.84ms - 52.08msunsure 🔍
-4% - +3%
-1.83ms - +1.29ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.00ms - 5.32ms-unsure 🔍
-2% - +5%
-0.10ms - +0.24ms
preact-main5.02ms - 5.16msunsure 🔍
-5% - +2%
-0.24ms - +0.10ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.38ms - 16.83ms-unsure 🔍
-2% - +2%
-0.26ms - +0.36ms
preact-main16.34ms - 16.78msunsure 🔍
-2% - +2%
-0.36ms - +0.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 120
  • Built by: CI #6254
  • Commit: 28f916d

duration

VersionAvg timevs preact-localvs preact-main
preact-local59.23ms - 62.04ms-unsure 🔍
-3% - +3%
-1.99ms - +1.84ms
preact-main59.41ms - 62.01msunsure 🔍
-3% - +3%
-1.84ms - +1.99ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.03ms - 3.03ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.03ms - 3.03msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local17.18ms - 17.45ms-faster ✔
2% - 4%
0.36ms - 0.77ms
preact-main17.73ms - 18.03msslower ❌
2% - 4%
0.36ms - 0.77ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local19.39ms - 19.93ms-faster ✔
0% - 4%
0.09ms - 0.89ms
preact-main19.86ms - 20.44msslower ❌
0% - 5%
0.09ms - 0.89ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local20.88ms - 21.38ms-faster ✔
1% - 4%
0.11ms - 0.85ms
preact-main21.34ms - 21.89msslower ❌
1% - 4%
0.11ms - 0.85ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local22.72ms - 23.39ms-unsure 🔍
-4% - +0%
-0.98ms - +0.03ms
preact-main23.16ms - 23.90msunsure 🔍
-0% - +4%
-0.03ms - +0.98ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local16.06ms - 16.50ms-faster ✔
3% - 7%
0.54ms - 1.18ms
preact-main16.91ms - 17.37msslower ❌
3% - 7%
0.54ms - 1.18ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.06ms - 22.11ms-faster ✔
2% - 8%
0.33ms - 1.79ms
preact-main22.14ms - 23.15msslower ❌
1% - 8%
0.33ms - 1.79ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #6254
  • Commit: 28f916d

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.71ms - 1.85ms-unsure 🔍
-2% - +9%
-0.04ms - +0.15ms
preact-main1.66ms - 1.79msunsure 🔍
-9% - +2%
-0.15ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.00ms - 1.01ms-faster ✔
1% - 4%
0.01ms - 0.04ms
preact-main1.01ms - 1.05msslower ❌
1% - 4%
0.01ms - 0.04ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local23.34ms - 24.55ms-unsure 🔍
-3% - +3%
-0.71ms - +0.70ms
preact-main23.59ms - 24.31msunsure 🔍
-3% - +3%
-0.70ms - +0.71ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k
  • Browser: chrome-headless
  • Sample size: 150
  • Built by: CI #6254
  • Commit: 28f916d

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.01ms - 29.51ms-unsure 🔍
-2% - +6%
-0.48ms - +1.58ms
preact-main27.51ms - 28.92msunsure 🔍
-5% - +2%
-1.58ms - +0.48ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.01ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.00ms - 3.01msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@coveralls

coveralls commented Nov 18, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 99.857% (-0.001%) from 99.858% — golf/inline-render-component into main

auto-merge was automatically disabled November 18, 2026 10:48

Pull request was closed

@JoviDeCroock JoviDeCroock reopened this Nov 18, 2026
@JoviDeCroock
JoviDeCroock merged commit 39310e5 into main Nov 18, 2026
25 checks passed
@JoviDeCroock
JoviDeCroock deleted the golf/inline-render-component branch November 18, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants