Repository navigation
Inline renderComponent into the render queue loop - #5383
Merged
Merged
Conversation
renderComponent() had a single caller. Its body now runs inside process(), behind the same two checks (dirty, still has a _parentDom). The callback that walks the parent _dom pointers now captures a local of process(), which runs once per flush, instead of one of renderComponent(), which ran once per component.
|
Size Change: -4 B (-0.02%) Total Size: 16.2 kB 📦 View Changed
ℹ️ View Unchanged
|
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
JoviDeCroock
enabled auto-merge
November 18, 2026 10:47
auto-merge was automatically disabled
November 18, 2026 10:48
Pull request was closed
marvinhagemeister
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderComponent()had a single caller. Its body now runs insideprocess(), behind the same two checks: the component is dirty and still has a_parentDom.The callback that walks the parent
_dompointers (#5380) now captures a local ofprocess(), which runs once per flush, instead of one ofrenderComponent(), which ran once per component.Saves 4 B gzip in core.
Note
Written with the help of Fable 5.2