Repository navigation
feat(ios): Purse UI for the CASH card - #1867
Open
filvecchiato wants to merge 24 commits into
Open
filvecchiato wants to merge 24 commits into
filvecchiato wants to merge 24 commits into
Conversation
Contributor
|
This pull request touches an app, which is not built by default. Add a label for each build you want:
Each starts as soon as it is added and follows the branch from then on. |
This was referenced Nov 3, 2026
Merged
Contributor
Bundle size reportCompared with
WebAssembly modules
No file changed size. Commit: 1b2872e |
Contributor
|
CI Status: 24 required jobs green, 16 passed and 8 skipped by path filter. All job results
Signing credentials: valid as of 2026-11-06 Commit |
…osts/ios-funding-3a-purse
…osts/ios-funding-3a-purse
…osts/ios-funding-3a-purse
…osts/ios-funding-3a-purse # Conflicts: # hosts/ios/polkadot-app/Modules/AssetDetails/AssetDetailsViewLayout.swift # hosts/ios/polkadot-app/Modules/AssetDetails/Model/Coins/CoinageBalanceBreakdownView.swift # hosts/ios/polkadot-app/Modules/Wallet/WalletMain/WalletMainViewController.swift
…osts/ios-funding-3a-purse
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1267. Stacked on #1866.
The Purse: what the CASH card opens into on the wallet screen.
AssetDetailsBalanceCard), the coinage split bar and coin field, and the asset-details layout with Total amounts. The Total panel with its split bar replacesCoinageBalanceBreakdownView, which is deleted; the card's view model drops the ready balance and logo it no longer draws.CoinageCoinField.dropping(onto:)).Funding.card*strings and subtitled with the payment asset's symbol (cash.symbol). The old Get/Send and wallet-card strings they replace are removed.PurseMotion/PurseScroll: the card collapses into the navigation bar as the Purse scrolls (PurseFloatingCard,PurseTitleView), with Reduce Motion respected.PurseMotionholds only the collapse and Total panel timings here; the activity rows' timings land with them in feat(ios): funding overlay screens and activity #1868.WalletMainViewControllerputs the Purse title view in the navigation bar while the Purse is open, and clears it again when the Purse closes on iOS below 26, where the main title sits on the left.FundingCash+Current.swiftholdsFundingCash.current, the app's payment asset.Funding.xcstringsgains the strings the Purse uses.PurseMotionTests(collapse progress and frames, smoothstep, fades, sticky bar, split bar share and stripes).PurseSnapshotTestsis a manual check, not an assertion: whenPURSE_SNAPSHOT_DIRis set (TEST_RUNNER_PURSE_SNAPSHOT_DIRthrough xcodebuild) it writes PNGs of the open Purse at fixed scroll offsets for checking by eye, and is skipped otherwise.Get/Send and the funding entry points are wired in #1345.
Stack (iOS funding, review bottom-up):
main)funding/host-gaps, feat(truapi)!: crypto networks, learned limits, retrying, payout and refunds for the funding screens #1344)Split out of #1345 as requested in review.