Repository navigation
feat(ios): wire the CASH card and the core to the funding overlay; remove the getcash path - #1345
Open
filvecchiato wants to merge 177 commits into
Open
filvecchiato wants to merge 177 commits into
filvecchiato wants to merge 177 commits into
Conversation
Contributor
|
This pull request touches an app, which is not built by default. Add a label for each build you want:
Each starts as soon as it is added and follows the branch from then on. |
2 tasks
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (10)
Commit: e819f1d |
Contributor
|
CI Status: 24 required jobs green, 16 passed and 8 skipped by path filter. All job results
Signing credentials: valid as of 2026-11-03 Commit |
This reverts commit b2a3c8b.
This reverts commit 73f0431.
The app's network TLD is testnet, so fundtest-provider.dot never parsed as a page: present_provider_frame answered Dismissed at once and the provider ended every card and bank session as Cancelled.
…r screens close A failed session shows its reason on the deposit and summary screens and in the CASH card history, which stores an Other failure's message (UserDataModel55). Selection, cancel and open errors are no longer dropped. The provider frame's back and sent-funds buttons hide it without answering, since the provider takes an early answer as the user giving up; a session under In Progress reopens its deposit screen and any frame still waiting.
…o hosts/ios-funding-2-core
…to hosts/ios-cash-card
This was referenced Nov 3, 2026
Open
filvecchiato
added a commit
that referenced
this pull request
Nov 3, 2026
This was referenced Nov 3, 2026
…o hosts/ios-funding-2-core
…osts/ios-funding-3a-purse
… hosts/ios-funding-3b-overlay
…to hosts/ios-cash-card
…s-funding-2-core # Conflicts: # hosts/ios/polkadot-appTests/Products/TrUAPIWorkerManagerTests.swift
…osts/ios-funding-3a-purse
… hosts/ios-funding-3b-overlay
…to hosts/ios-cash-card
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1267. Builds on #1868.
Wires the CASH card and the core to the funding overlay, and removes the getcash path. The pieces it wires land in the PRs below.
Wiring
TrUAPIHostRuntimeProviderinstallsAppFundingHostBridgeoverAppFundingOverlay(withAppFundingEnvironment) on the runtime before any execution opens, so a product's Funding request never answers unsupported. It also routesworkerCrashingto the overlay and attachesFundingActivityCenter.FundingOpening/RuntimeFundingOpeneropens a session on the host's own behalf. The CASH card's Get (asset details) and Send (search account) open the overlay through it, or show the sessions still in flight. Failures are worded for the user.ServiceCoordinatorstarts the core when a provider was still working on a session last run (FundingResumeMarker), after payments are attached.getcash removal
funding_configno longer carriesonrampUrl/offrampUrl. Remote config reads onlyproviders(feat(ios): funding core integration — FFI bindings, session model, provider listing, worker exits #1866).FundingDomainProvider,RampActionand its error texts,ProductAutoAllowList,AutoAllowProductPermissionRequester,AutoAllowPaymentApprovalRequester(and their tests), and the getcash product labels and strings. Permission and payment approval requesters no longer take a funding provider.Tests: unit tests build; the simulator test runner hangs, so they have not run. The Nightly app builds.
Stack (iOS funding, review bottom-up):
main)funding/host-gaps, feat(truapi)!: crypto networks, learned limits, retrying, payout and refunds for the funding screens #1344)Split into the stack above as requested in review.