Repository navigation
Remove dead code, fix mypy error, count bare-byte DRM allocations - #64
Closed
offbyonebit wants to merge 1 commit into
Closed
offbyonebit wants to merge 1 commit into
offbyonebit wants to merge 1 commit into
Conversation
Remove unreferenced AgentError, format_assistant_tool_call, AutoTuner._last_used_at, gguf_vram_estimate, Router.backend_url_for and ChatStore.wipe. Type the entry_points() result in plugin discovery so mypy passes. Treat bare-number drm-total-* fdinfo values as bytes so external llama-server allocations without a unit suffix are detected, and exclude drm-total-cycles* counters explicitly.
This was referenced Oct 6, 2026
Merged
Owner
Author
|
Closing as superseded by merged PR #68 (48bc7e9), which is an ancestor of current main. Verified the original text patches against that merge and the four UI image blobs by Git blob SHA. The plugin annotation from #64 is present; its surrounding fallback also received a safer getattr check. No outstanding changes from these PRs remain. |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small cleanup on top of the RC2 follow-up branch.
AgentError,format_assistant_tool_call,AutoTuner._last_used_at,gguf_vram_estimate,Router.backend_url_for,ChatStore.wipe(and theshutilimport it left unused).entry_points()result in plugin discovery somypy --check-untyped-defs srcpasses.gpu_ownership: treat bare-numberdrm-total-*fdinfo values as bytes (the DRM spec allows a missing unit), and exclude alldrm-total-cycles*counters explicitly. Added tests for both.Testing
test_semantic_search_requires_optional_dependency, which only passes whenfastembedis not installed; with all extras it tries to download a model and was blocked by the sandbox proxy.Not run: Windows, Alchemist, Lunar Lake, native GPU inference, Docker build.
Generated by Claude Code