Skip to content

Add Tamil (தமிழ்) translation - #280

Open
SmartManoj wants to merge 2 commits into
nohello-net:mainfrom
SmartManoj:main
Open

SmartManoj wants to merge 2 commits into
nohello-net:mainfrom
SmartManoj:main

Conversation

@SmartManoj

Copy link
Copy Markdown

Adds Tamil (தமிழ்) at /ta/.

Changes

  • locales/ta/messages.po: Tamil translation of all 32 strings.
  • src/ta/: page files, created with bin/make-language.sh ta.
  • src/_data/locales.json: Tamil listed between svenska and Türkçe.
  • src/js/nohello.js: adds வணக்கம் to the typed greetings, in Tamil script as suggested in added greeting in Tamil 'vanakkam' in nohello.js #150.

Translation notes

  • Names are transliterated (டிம், கீத், டான்) to match the avatars from The Office.
  • Timestamps use the Tamil day period: பிற்பகல் 2:15.
  • example.bad.message2.body keeps a deliberate typo (மனிக்கு for மணிக்கு) and a casual tone, as the source comment asks.

Testing

  • yarn test:unit: 566 passing, including all 29 checks for the Tamil locale.
  • Built the site and checked /ta/ in Chromium at desktop and phone widths: markdown, links and the year render correctly, with no horizontal overflow.
  • I did not update test/ui/snapshot.spec.ts-snapshots/index-linux.png. The English footer now has one more language link, so the snapshot needs a refresh with yarn update-snapshots.

🤖 Generated with Claude Code

- locales/ta/messages.po: full Tamil translation of all strings
- src/ta/: page files, made with bin/make-language.sh
- src/_data/locales.json: list Tamil between svenska and Türkçe
- src/js/nohello.js: add the Tamil greeting வணக்கம் to the typed list

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 05:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new footer link changes the full-page screenshot, but the English baseline remains unchanged, causing the UI snapshot assertion to fail in CI.

1 open issue
What changed in this PR

Adds Tamil (தமிழ்) at /ta/ using the site’s existing localization system.

Changes:

  • Translates all 32 strings into Tamil, including localized names and timestamps.
  • Adds Tamil page files and registers the language in the footer.
  • Adds வணக்கம் to the animated greetings, following the Tamil-script suggestion in #150.
File Description
src/​ta/​ta.11tydata.ts Initializes Tamil locale data.
src/​ta/​index.njk Creates the Tamil page using the shared template.
src/​js/​nohello.js Adds the Tamil greeting to the animation.
src/​_data/​locales.json Registers Tamil in the language list.
locales/​ta/​messages.po Provides all 32 Tamil translations.

Review effort: Balanced

Comment thread src/_data/locales.json Resolved
The English page now lists தமிழ் in its footer, so the full-page
snapshot changes. This baseline comes from the ui-test job of the CI
fix (mcr.microsoft.com/playwright:v1.20.1-focal, year pinned to 2022),
where it passes with this PR on top.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants