[raft/scd] Extract create and update subscription - #1645
Merged
mickmis merged 1 commit intoAug 31, 2026
Merged
Conversation
MariemBaccari
force-pushed
the
scd_extract_create_update_subscription
branch
from
August 19, 2026 13:03
6dcbb87 to
d035011
Compare
MariemBaccari
marked this pull request as ready for review
August 19, 2026 13:10
This was referenced Aug 19, 2026
MariemBaccari
force-pushed
the
scd_extract_create_update_subscription
branch
from
August 19, 2026 14:19
d035011 to
8f0b721
Compare
This was referenced Aug 19, 2026
barroco
added
the
dss-raft
This was referenced Aug 20, 2026
mickmis
approved these changes
Aug 26, 2026
| } | ||
|
|
||
| // Validate and perhaps correct StartTime and EndTime. | ||
| if err := subreq.AdjustTimeRange(timestamp.MustGetRequestTimestamp(ctx), old); err != nil { |
Contributor
There was a problem hiding this comment.
FTR: checked the previous DefaultClock was never assigned to anything else than RealClock, so doing so is OK.
This was referenced Aug 28, 2026
MariemBaccari
force-pushed
the
scd_extract_create_update_subscription
branch
from
August 28, 2026 09:43
8f0b721 to
72fe436
Compare
This was referenced Aug 28, 2026
MariemBaccari
force-pushed
the
scd_extract_create_update_subscription
branch
from
August 28, 2026 11:46
72fe436 to
e9082a9
Compare
This was referenced Aug 28, 2026
This was referenced Aug 28, 2026
mickmis
approved these changes
Aug 31, 2026
MariemBaccari
force-pushed
the
scd_extract_create_update_subscription
branch
from
August 31, 2026 12:14
e9082a9 to
cd83a44
Compare
Contributor
|
Note: ignored failed CI run, see #1660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract create and update subscription business logic.
Implements #1701