[raft/scd] Implement operational intents repo methods - #1672
Open
MariemBaccari wants to merge 9 commits into
Open
MariemBaccari wants to merge 9 commits into
MariemBaccari wants to merge 9 commits into
Conversation
This was referenced Aug 28, 2026
MariemBaccari
marked this pull request as ready for review
August 28, 2026 14:47
MariemBaccari
force-pushed
the
raft_scd_operational_intents
branch
from
August 31, 2026 09:44
5d7f577 to
3533dbc
Compare
MariemBaccari
force-pushed
the
raft_scd_operational_intents
branch
2 times, most recently
from
September 15, 2026 08:28
a595fdc to
c7ec73d
Compare
This was referenced Sep 15, 2026
MariemBaccari
force-pushed
the
raft_scd_operational_intents
branch
6 times, most recently
from
September 21, 2026 23:22
65bf244 to
88181ac
Compare
mickmis
approved these changes
Sep 22, 2026
Comment on lines
+25
to
+28
| buf, err := json.Marshal(id) | ||
| if err != nil { | ||
| return nil, stacktrace.Propagate(err, "failed to marshal payload") | ||
| } |
Contributor
There was a problem hiding this comment.
Not for this PR, but with the look of it, looks like we could be pushing the marshalling of the value into HandleClientRequest and change the type of value to any. Except if some operations have more complex things going on?
Contributor
Author
There was a problem hiding this comment.
With the gate 1 work (#1709), I will look into payload size optimizations and that should include investigating custom encoding per payload type. I kept the marshalling outside so that consensus can receive an opaque payload like it would with custom encoding.
I referenced your suggestion in the contributions spreadsheet to keep it in mind in case we don't end up going with custom encoding for some reason. Is it okay if I revisit later ?
MariemBaccari
force-pushed
the
raft_scd_operational_intents
branch
from
September 23, 2026 00:18
88181ac to
579e236
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the scd opintents repo methods for the raftstore. The raftstore repo methods issue individual proposals.
Implements #1700