Skip to content

allow json format via zenoh, rvised test, multiple config files, deactivated autostart of zenoh bridge at cli startup - #105

Merged
akoerner1 merged 1 commit into
developfrom
feature/zenoh-bridge-json-multi-config
Sep 19, 2026
Merged

akoerner1 merged 1 commit into
developfrom
feature/zenoh-bridge-json-multi-config

Conversation

@n-mat

@n-mat n-mat commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Description

This PR:

  • deactivates the autostart of the zenoh bridge with the adore cli -> zenoh bridge needs to be started manually or together with the secenario launch file
  • adds 'config_paths' launch parameter to zenoh bridge. This feature allows to have multiple config files in different directories to configure the zenoh bridge
  • adds changes for json (non-ROS) clients
  • should not change behaviour for ROS clients

Fixes #(issue-number)

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) -> Deactivated autostart of zenoh bridge -> Manual start required with launch file
  • Documentation update (adds or updates documentation)
  • Refactor (non-breaking change for code readability/structure)
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code.
  • I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/.
  • My last commit was made with the --signoff flag as required by the Eclipse Foundation.
  • I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary.
  • I have added tests that prove my fix is effective or that my feature works.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce.

The test is described in ros2_workspace/src/adore_interfaces/zenoh_message_bridge/README.md

Signed-off-by: n-mat <matthias.nichting@dlr.de>
@n-mat n-mat self-assigned this Sep 13, 2026
@n-mat
n-mat requested a review from tlobig September 13, 2026 13:42

@tlobig tlobig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes look sensible, I could not fully test with my setup and therefore must trust in testing done by PR owner

@n-mat

n-mat commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

@MikkelDLR please check

@n-mat

n-mat commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

successfully tested together with @MikkelDLR

@n-mat
n-mat requested a review from akoerner1 September 16, 2026 17:02
@akoerner1
akoerner1 merged commit f8bc415 into develop Sep 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants