Repository navigation
Keep render tool results as Preview paths; hydrate before the model - #4971
Merged
Merged
Conversation
…he model. Stops base64 image blocks from riding bash/stream/event tool output into session history and gateway NDJSON (VQA Err truncation). GenerationTask.beforeRequest reloads cached previews for the LLM only; drop retired npm dimcode from install-test-clis.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: aaf8323 | Previous: 2e7688b | Ratio |
|---|---|---|---|
peak memory |
1748.297 MB |
1716.07 MB |
1.02 |
peak threads |
364 threads |
374 threads |
0.97 |
network (transport) |
2724.091 MB |
2725.848 MB |
1.00 |
disk write |
1.758 MB |
1.738 MB |
1.01 |
instructions |
137.219 G |
136.431 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4971 +/- ##
==========================================
+ Coverage 83.00% 83.08% +0.08%
==========================================
Files 1752 1752
Lines 169315 169315
Branches 13955 13955
==========================================
+ Hits 140542 140681 +139
+ Misses 25017 24978 -39
+ Partials 3756 3656 -100
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Drop the evals CLI and comment-only edits so the change is just Preview paths + beforeRequest hydrate.
Contributor
Author
Contributor
 [Medium impact] No blocking findings remain. The outstanding photo-clip encoding concern is non-blocking. Findings
SummaryKeeps rendered tool results as text paths and structured file references, then adds images only to the next model request.
Reviews (6) · Last reviewed commit: "Seal verified clip frame bytes into a te..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Addresses Greptile P1s: stop reading arbitrary Preview: paths, rebuild model images from trusted sources when the cache is gone, and keep event exports on the draft so truncation cannot drop them.
Contributor
Author
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
Closes the remaining Greptile cache-lifetime P1: when RenderCache drops a contact sheet, restore the model image by re-rendering the trusted source instead of omitting it.
Contributor
Author
Contributor
Author
|
@greptileai please re-review — clip rebuild now verifies each view.clip.frames source.sha256 via readVerified before re-rendering (c4dabc5). |
The renderer must consume the same hashed bytes recorded on the tool result, not re-read the live tree after a separate check.
Contributor
Author
|
@greptileai please re-review — clip rebuild now seals readVerified frame bytes into a temp index (with those sha256s) and renders only that copy, so the renderer never re-reads the live tree (5858134). |
moshiii-wei
marked this pull request as ready for review
November 1, 2026 18:04
moshiii-wei
requested review from
Dreamsorcerer,
TomCC7,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
November 1, 2026 18:04
github-actions
Bot
added
the
ready-to-merge
moshiii-wei
enabled auto-merge (squash)
November 1, 2026 18:04
github-actions
Bot
removed
the
ready-to-merge
spomichter
approved these changes
Nov 2, 2026
github-actions
Bot
added
the
ready-to-merge
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preview:paths +details.renderFileRefs instead of inlining base64 image blocks (fixes gateway NDJSON truncation / VQA Err).GenerationTask.beforeRequestso the model still sees them.Test plan
npm run typecheckindimos/agentspreview-refs/render/clip/points/boundaries/intaketestsnpm test(remaining flakes unrelated to this change)