Repository navigation
Flakey: fix test_a_trajectory_reaches_the_fake_arm_and_the_base_is_told_to_stand_still - #4965
Merged
Conversation
…f its target A runner stall longer than the 0.2 s reading timeout makes the coordinator skip the trajectory final command and hold the arm where it last reported. The tests now wait 10 s for readings, except the restart test, which needs the silence noticed.
mustafab0
requested review from
Dreamsorcerer,
TomCC7,
aclauer,
leshy,
paul-nechifor and
spomichter
as code owners
November 1, 2026 00:55
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 60b0fee | Previous: d2fb73c | Ratio |
|---|---|---|---|
peak memory |
1752.172 MB |
1737.02 MB |
1.01 |
peak threads |
379 threads |
371 threads |
1.02 |
network (transport) |
2736.299 MB |
2733.743 MB |
1.00 |
disk write |
1.711 MB |
1.699 MB |
1.01 |
instructions |
138.151 G |
136.49 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
 [Low impact] Safe to merge within the reviewed scope: trajectory completion and restarted-arm holding both passed with the updated fixture configuration. SummaryRaises the test fixture’s default
Reviews (1) · Last reviewed commit: "test(control): a frozen test machine no ..." · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4965 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 1752 1752
Lines 169252 169253 +1
Branches 13952 13952
=======================================
+ Hits 140610 140615 +5
+ Misses 24985 24984 -1
+ Partials 3657 3654 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
ready-to-merge
paul-nechifor
approved these changes
Nov 1, 2026
paul-nechifor
deleted the
mustafa/fix/flaky_test_a_trajectory_reaches_the_fake_arm_and_the_base_is_told_to_stand_still
branch
November 1, 2026 02:12
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CI runner freeze longer than the coordinator's 0.2 s reading timeout dropped the trajectory's single final command and left the arm short of TARGET, so the fixture now uses a 10 s reading timeout, with the restart test keeping 0.2 s because it relies on that silence being noticed.