Repository navigation
fix(evals): robosuite scenes keep robosuite's elliptic contact cone - #4902
Closed
ruthwikdasyam wants to merge 1 commit into
Closed
ruthwikdasyam wants to merge 1 commit into
ruthwikdasyam wants to merge 1 commit into
Conversation
The exported robosuite scenes lost robosuite's <option cone="elliptic" impratio="20"> and ran on MuJoCo's pyramidal default, so a grasped object crept out of the closed gripper (about 0.27 mm/s) until it fell. With robosuite's settings the creep is about 0.003 mm/s and the object holds.
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 44b5520 | Previous: 1216a55 | Ratio |
|---|---|---|---|
peak memory |
1699.723 MB |
1705.691 MB |
1.00 |
peak threads |
368 threads |
366 threads |
1.01 |
network (transport) |
2727.914 MB |
2725.831 MB |
1.00 |
disk write |
1.742 MB |
1.664 MB |
1.05 |
instructions |
134.994 G |
135.978 G |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 6 robosuite scenes (
data/.lfs/robosuite.tar.gz) lost robosuite's<option cone="elliptic" impratio="20">on export. On MuJoCo's pyramidal default, a grasped object creeps out of the closed gripper (about 0.27 mm/s) and falls. More pad friction or gripper force does not fix it.Fix
Each
scene.xmlnow has<option integrator="implicitfast" cone="elliptic" impratio="20" />, as robosuite 1.5.2 does. Creep drops to about 0.003 mm/s and the object holds. No code change.Test
All 6 scenes load and step in MuJoCo with
cone=elliptic,impratio=20.Note:
get_datadoes not re-extract an existingdata/robosuite/; delete it locally to pick up the new archive.