Repository navigation
Conversation
1 task
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 7edb281 | Previous: f9c5a5c | Ratio |
|---|---|---|---|
peak memory |
1774.52 MB |
1795.23 MB |
0.99 |
peak threads |
359 threads |
366 threads |
0.98 |
network (transport) |
2731.023 MB |
2730.945 MB |
1.00 |
disk write |
1.5 MB |
1.723 MB |
0.87 |
instructions |
137.827 G |
137.801 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mustafab0
force-pushed
the
mustafa/feat/operator-ui-page
branch
from
October 23, 2026 01:00
e419ec4 to
df2a447
Compare
mustafab0
force-pushed
the
mustafa/feat/operator-ui-estop
branch
from
October 23, 2026 01:00
7a21ea9 to
b2eb928
Compare
mustafab0
force-pushed
the
mustafa/feat/operator-ui-estop
branch
from
October 23, 2026 19:30
b2eb928 to
2d6cbd7
Compare
mustafab0
force-pushed
the
mustafa/feat/operator-ui-page
branch
from
October 23, 2026 19:30
df2a447 to
24e0d00
Compare
mustafab0
force-pushed
the
mustafa/feat/operator-ui-estop
branch
from
October 23, 2026 21:56
2d6cbd7 to
c2d6a89
Compare
mustafab0
force-pushed
the
mustafa/feat/operator-ui-page
branch
from
October 23, 2026 21:56
24e0d00 to
ce47c47
Compare
OperatorHoldCoordinator takes an e-stop on a new operator_estop stream of
Bool. True latches set_estop(True), requests the operator hold (route
failsafe, reason e-stop) so every joint is frozen where it is, and
cancels the running trajectory. False only clears the latch; the hold
stays on until the operator acknowledges it. The latch state goes out
on operator_estop_status as an OperatorEstopStatus (estopped, stamp in
unix seconds) at start and on every set_estop. OperatorEstopStatus sits
beside OperatorHoldCommand so modules outside the blueprint can read it.
hybrid-teleop-sim exposes both as web channels: operator_estop with the
built-in bool.json.v1 decoder (the page sends a bare true or false) and
operator_estop_status paced, so a second change right after the first
still reaches the page. web/hybrid-teleop gets an E-STOP button, Clear
e-stop, an E-STOP ACTIVE line, and Take over / Resume in place of
Acknowledge. Both send action "acknowledge" with a new OperatorHoldCommand
intent field ("takeover" or "resume") that the hold task does not read.
1 task done
mustafab0
force-pushed
the
mustafa/feat/operator-ui-estop
branch
from
October 23, 2026 23:41
c2d6a89 to
7edb281
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #4789
Why do we need this?
The operator needs a stop that halts a running move at once and stays visible, and a clear choice of how to end the hold.
What is this feature?
E-stop, Take over and Resume on the operator page.
OperatorHoldCoordinatortakesoperator_estop, aBool(true stops, false clears; the page sends a bare JSONtrueorfalsethrough the built-inbool.json.v1decoder), and publishesoperator_estop_status, anOperatorEstopStatus(estopped,stampin unix seconds). Stop latches E-STOP, requests a failsafe hold and cancels the trajectory; clear leaves the hold on. The blueprint declares both channels (the e-stop status paced). The page adds E-STOP, Clear e-stop, an E-STOP ACTIVE line, and Take over / Resume, which both acknowledge the hold with anintentof "takeover" or "resume".How to manually run this
dimos run hybrid-teleop-sim --serve-dir web/hybrid-teleop, then open http://localhost:7780.While the arm is moving, click E-STOP: the arm stops and E-STOP ACTIVE shows. Click Clear e-stop: the hold stays on. Click Resume: the hold ends.
Tested: coordinator unit tests. Headless sim with a scripted browser: idle → E-STOP during a move → clear → resume; the arm stops within about 0.3 s.
Which issue(s) does this PR close?
None.
Checklist