Skip to content

pc/1.21.4: recipes from the 1.21.4 generator module - #1315

Open
Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:masterfrom
Pix3lPirat3:fix/pc-1.21.4-recipes
Open

Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:masterfrom
Pix3lPirat3:fix/pc-1.21.4-recipes

Conversation

@Pix3lPirat3

@Pix3lPirat3 Pix3lPirat3 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

The file was the 1.21.3 one: no resin, resin brick or creaking heart recipes, missing dye and suspicious stew variants, and the map-extending recipe as item 0. Regenerated with PrismarineJS/minecraft-data-generator#90: 8 items added, air entry gone, 45 plank recipes re-expanded for pale_oak_planks.


Companion PRs: generated by PrismarineJS/minecraft-data-generator#90 (1.21.4 module) and PrismarineJS/minecraft-data-generator#89 (skip recipes that assemble to air). Review those alongside; the data here is committed so it does not strictly block.

The file was the 1.21.3 one: no resin, resin brick or creaking heart recipes, missing dye and suspicious stew variants, and the map-extending recipe as item 0. Regenerated with PrismarineJS/minecraft-data-generator#90: 8 items added, air entry gone, 45 plank recipes re-expanded for pale_oak_planks.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

No blocking issue found in this data update. I checked all 1,568 candidate entries against the recipes and recursively expanded item tags in Mojang’s official 1.21.4 server jar: each input shape/ingredient multiset and result item/count has a matching vanilla recipe. The previous file’s only unmatched entry in that check was the air result, which this PR removes. The eight new result IDs resolve correctly, the schema validates, and all entries construct through the actual prismarine-recipe consumer.

This check covers the represented item IDs, counts and ingredients; it does not claim full component-sensitive crafting or live Mineflayer crafting validation. Existing limitations such as cake remainders are unchanged by this diff.

Skills used: prismarine-protocol-data-review checked category routing and generated data against its version-specific source; prismarine-item-inventory-review traced the real recipe consumer and separated inherited limitations from this change; prismarine-review checked existing feedback.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants