Repository navigation
Skip recipes that assemble to air (map extending) - #89
Pix3lPirat3 wants to merge 1 commit into
Conversation
Since 1.21.3 recipes.json had an entry under item 0: the map-extending recipe computes its result at craft time, so assembling it with an empty input yields air. Skip shaped and shapeless recipes with an empty result in the 1.21.3 - 26.1 folders
3742f21 to
2d864d0
Compare
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
No blocking issue found in the bounded empty-result guard. I checked all nine changed version modules: both shaped and shapeless paths are covered, using the same version-specific craft/assemble API already used below. The official 1.21.4 MapExtendingRecipe implementation confirms why empty input produces an empty result, while ordinary shaped/shapeless recipes return their stored result. The companion 1.21.4 module includes the same guard; its committed data has no air recipe and all 1,568 entries match official recipe inputs and result IDs/counts.
I have not rebuilt and run every affected generator version, so this is a source and downstream-data review, not a claim of nine-version regeneration.
Skills used: prismarine-protocol-data-review checked version-specific extractor paths and authoritative game data; prismarine-item-inventory-review checked the supported static recipe representation; prismarine-review checked existing discussion and the scope of the fix.
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The bounded empty-result guard remains sound in both shaped and shapeless paths across the nine changed modules; the earlier review records the native MapExtendingRecipe and downstream-data evidence.
The refreshed matrix has a failed Build 1.19 job, so the remaining action is to diagnose/rerun that integration check before landing. I am not attributing that failure to this guard without the evidence, or claiming that all nine modules were freshly regenerated. There is no additional root-cause comment to duplicate.
Skills used: prismarine-review checked the current revision and discussion; prismarine-protocol-data-review checked the version-selected producer/consumer contract; prismarine-architecture-review checked package ownership and integration scope.
There was a problem hiding this comment.
Per Copilot, no changes needed for 26.2
Since 1.21.3 recipes.json had an entry under item 0: the map-extending recipe computes its result at craft time, so assembling it with an empty input yields air. Skip shaped and shapeless recipes with an empty result in the 1.21.3 - 26.1 folders
Companion PRs: regenerated data is in PrismarineJS/minecraft-data#1315.