Repository navigation
Fail loudly when the Pi4J/download push fails - #772
Merged
Merged
Conversation
The retry loop's "git push origin main && break" never propagated a
final failure: when all 3 attempts failed, the script fell through to
the loop's last command (git pull --rebase, which succeeds trivially
when there's nothing to rebase), so the step - and the whole job -
reported success while never actually pushing anything.
This is exactly what's been happening since 2026-07-02: every
snapshot build's "Deploy to Download Repo" job has reported green,
but Pi4J/download hasn't received a real commit since, because
API_TOKEN_GITHUB has been failing auth
("fatal: could not read Password ... No such device or address")
on every push attempt, silently.
Now exits 0 only on an actual successful push, and exits 1 with a
clear ::error:: annotation if all 3 attempts fail.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The final rebase can fail before the new error annotation is emitted.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Ensures failed snapshot pushes to Pi4J/download no longer report success.
Changes:
- Exits successfully only after a successful push.
- Reports an error after exhausting retries.
| File | Description |
|---|---|
.github/workflows/ci-main-snapshot.yml |
Corrects snapshot push failure propagation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add retry logic for push attempts in CI workflow Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This was referenced Oct 1, 2026
eitch
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
ci-main-snapshot.yml's "Deploy to Download Repo" job retry loop never propagated a final failure. When all 3git pushattempts fail, the script fell through to the loop's last command (git pull --rebase, which succeeds trivially when there's nothing new to rebase), so the step — and the whole job — reported success while never actually pushing anything.This is exactly what's been silently happening since 2026-07-02: every snapshot build's deploy-to-download step has been green, but Pi4J/download hasn't received a real commit since then, because
API_TOKEN_GITHUBhas been failing auth on every push attempt:(Separately being investigated — this PR only fixes the silent-failure part so the real problem surfaces instead of being masked.)
Fix
0only on an actual successful push.1with a clear::error::annotation if all 3 attempts fail, so the job goes red and shows up in notifications/status checks instead of silently doing nothing.Test plan
API_TOKEN_GITHUBis confirmed valid, verify the next snapshot build actually pushes toPi4J/downloadand the job stays green.🤖 Generated with Claude Code