Skip to content

Add CI secrets maintenance note - #773

Merged
FDelporte merged 4 commits into
mainfrom
docs/ci-secrets-maintenance-note
Oct 1, 2026
Merged

FDelporte merged 4 commits into
mainfrom
docs/ci-secrets-maintenance-note

Conversation

@FDelporte

Copy link
Copy Markdown
Member

Summary

Adds .github/SECRETS.md documenting API_TOKEN_GITHUB and OSSRH_*, how to regenerate API_TOKEN_GITHUB, and an expiry log to fill in on each rotation.

Written up after API_TOKEN_GITHUB silently expired for three months (2026-07-02 → 2026-10-01) — every ci-main-snapshot.yml run reported green the whole time because the push-retry loop never checked for final failure (fixed separately in #772). Nobody had a record of what the token was for, where to regenerate it, or when it was last rotated, which made this much harder to diagnose than it needed to be.

Companion to a tracking issue for next year's renewal.

🤖 Generated with Claude Code

Documents API_TOKEN_GITHUB and OSSRH_* secrets, how to regenerate
them, and an expiry log to fill in on each rotation. Written up after
API_TOKEN_GITHUB silently expired for three months (2026-07-02 to
2026-10-01) with every CI run reporting green the whole time.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 08:49
@FDelporte
FDelporte requested review from eitch and taartspi October 1, 2026 08:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The secret inventory is inaccurate and the initial rotation still lacks the expiry date the document is intended to track.

Review effort: Balanced
Findings: 2 Low severity

Open (2)
What changed in this PR

Documents CI secret ownership, rotation steps, and the recent token-expiry incident.

Changes:

  • Adds secret usage and regeneration guidance.
  • Adds an expiry log and incident history.
File Description
.github/​SECRETS.md Documents CI secrets and token maintenance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/SECRETS.md Resolved
Comment thread .github/SECRETS.md Resolved
eitch
eitch previously approved these changes Oct 1, 2026
Updated usage of secrets in CI workflows for better clarity and added relevant files.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@eitch eitch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FDelporte
FDelporte merged commit 26088cb into main Oct 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants