Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/bump-iag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ body:
attributes:
label: Current binary version
description: The Compute binary version currently pinned in `mise.compute.toml`.
placeholder: "0.4.1"
placeholder: "0.5.2"
validations:
required: true

Expand All @@ -26,7 +26,7 @@ body:
attributes:
label: Target binary version
description: The proposed Compute binary version. Enter "Unchanged" if this pin does not move.
placeholder: "0.5.0"
placeholder: "0.6.0"
validations:
required: true

Expand All @@ -35,7 +35,7 @@ body:
attributes:
label: Current source version
description: The Compute source tag or revision currently pinned in `mise.compute.toml`.
placeholder: "0.4.1-bugfix.2"
placeholder: "0.5.2"
validations:
required: true

Expand All @@ -44,7 +44,7 @@ body:
attributes:
label: Target source version
description: The proposed Compute source tag or revision. Enter "Unchanged" if this pin does not move.
placeholder: "0.5.0"
placeholder: "0.6.0"
validations:
required: true

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/stdout_renderer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ jobs:
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
OPENSWIFTUI_OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH: ${{ matrix.attributegraph }}
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE: ${{ matrix.compute }}
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY: 0
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_SOURCE_VERSION: "0.4.1-bugfix.2"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY: 1
GH_TOKEN: ${{ github.token }}
steps:
- uses: actions/checkout@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ import SnapshotTesting
@MainActor
@Suite(.snapshots(record: .never, diffTool: diffTool))
struct AnimationCompletionUITests {
@Test(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for Compute snapshot crash. It works fine when this single test case. But it will crash when running the whole test plan"),
)
@Test
func logicalAndRemovedComplete() {
struct ContentView: AnimationTestView {
nonisolated static var model: AnimationTestModel {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import Testing

@MainActor
@Suite(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for IAG snapshot crash"),
.snapshots(record: .never, diffTool: diffTool)
)
struct MatchedGeometryEffectUITests {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import SnapshotTesting

@MainActor
@Suite(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for Compute snapshot crash. It will crash when running the whole test plan"),
.snapshots(record: .never, diffTool: diffTool),
)
struct ForEachUITests {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import SnapshotTesting

@MainActor
@Suite(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for Compute snapshot stack overflow. See https://github.com/jcmosc/Compute/issues/47"),
.snapshots(record: .never, diffTool: diffTool)
)
struct LabeledContentUITests {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import SnapshotTesting

@MainActor
@Suite(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for Compute snapshot stack overflow. See https://github.com/jcmosc/Compute/issues/47"),
.snapshots(record: .never, diffTool: diffTool)
)
struct LabelsHiddenModifierUITests {
Expand Down
4 changes: 1 addition & 3 deletions Example/OpenSwiftUIUITests/View/ProgressViewUITests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ struct ProgressViewUITests {
openSwiftUIAssertSnapshot(of: DefaultDateProgressLabelExample())
}

@Test(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for IAG snapshot crash")
)
@Test
func foundationProgress() {
openSwiftUIAssertSnapshot(of: FoundationProgressViewExample())
}
Expand Down
1 change: 0 additions & 1 deletion Example/OpenSwiftUIUITests/View/ToggleUITests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import SnapshotTesting

@MainActor
@Suite(
.disabled(if: attributeGraphVendor == .compute, "Temporarily disabled for Compute snapshot stack overflow. See https://github.com/jcmosc/Compute/issues/47"),
.snapshots(record: .never, diffTool: diffTool)
)
struct ToggleUITests {
Expand Down
4 changes: 1 addition & 3 deletions Example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ To use Compute instead, run setup with the Compute mise environment:
./setup.sh --compute
```

The Compute environment is defined in the repository's root `mise.compute.toml`. It disables the private AttributeGraph framework and resolves OpenSwiftUIProject/Compute from source at `0.4.1-bugfix.2`.

The Compute 0.4.0 and 0.4.1 binary releases are usable, but they have produced more UI test crashes than 0.3.0. The patched source release is therefore the default.
The Compute environment is defined in the repository's root `mise.compute.toml`. It disables the private AttributeGraph framework and uses the Compute 0.5.2 binary release by default. The same release is pinned for source-based builds.

## Generate Project

Expand Down
4 changes: 2 additions & 2 deletions Example/Tuist/Package.resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Scripts/CI/compute_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ clone_checkout_compute() {
revision=$(Scripts/CI/get_revision.sh compute 2>/dev/null || true)
fi
if [ -z "$revision" ]; then
revision="0.4.1-bugfix.2"
revision="0.5.2"
fi
cd ..
if [ ! -d Compute ]; then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ extension Subgraph {
}
}

// FIXME
extension Graph {
package typealias TraceFlags = TraceOptions
}

// MARK: - Defaultable [6.5.4]

package protocol Defaultable {
Expand Down Expand Up @@ -301,7 +296,7 @@ extension Graph {
_openSwiftUIUnimplementedFailure()
}

package static func startTracing(options: Graph.TraceFlags? = nil) {
package static func startTracing(options: Graph.TraceOptions? = nil) {
Graph.startTracing(nil, options: options ?? ProcessEnvironment.tracingOptions)
}

Expand Down
7 changes: 4 additions & 3 deletions mise.compute.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ tuist = "4.203.4"
TUIST_USE_SWIFTERPM=1
OPENSWIFTUI_OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH = "0"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE = "1"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY = "0"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY_VERSION = "0.4.1"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_SOURCE_VERSION = "0.4.1-bugfix.2"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY = "1"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY_VERSION = "0.5.2"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_BINARY_CHECKSUM = "0eca53a3620776cffcc3d2047d11efaf893b53078b95e59e793f86caa3f2c169"
OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE_SOURCE_VERSION = "0.5.2"
# OPENSWIFTUI_USE_LOCAL_DEPS = "1"
Loading