Repository navigation
Conversation
…uttons Added dynamic context (e.g., the specific header key being removed) to the `.help()` and `.accessibilityLabel()` modifiers of the icon-only removal buttons in the Webhook Headers forms across the app. This ensures VoiceOver users hear "Remove Content-Type header" instead of just "Remove header" repeatedly. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughRemoval controls for webhook headers, linked apps, and linked controllers now include the relevant item identifier in their help text and accessibility label. The palette adds guidance for contextual removal labels and linked-controller property names. ChangesContextual removal labels
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Merge Risk: 🔵 Low · up to The contextual removal labels behave as intended. A minor error in internal guidance may misdirect future maintenance, but has no established user-facing impact; the PR is otherwise mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…uttons Added dynamic context (e.g., the specific header key being removed) to the `.help()` and `.accessibilityLabel()` modifiers of the icon-only removal buttons in the Webhook Headers forms across the app. This ensures VoiceOver users hear "Remove Content-Type header" instead of just "Remove header" repeatedly. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
…uttons Added dynamic context (e.g., the specific header key or linked app bundle ID) to the `.help()` and `.accessibilityLabel()` modifiers of the icon-only removal buttons in list forms across the app. This ensures VoiceOver users hear "Remove com.apple.Safari" instead of just "Remove" repeatedly. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
…uttons Added dynamic context (e.g., the specific header key or linked app bundle ID) to the `.help()` and `.accessibilityLabel()` modifiers of the icon-only removal buttons in list forms across the app. This ensures VoiceOver users hear "Remove com.apple.Safari" instead of just "Remove" repeatedly. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
🤖 Managed by GLM-5.3 Flash (local model on kmacbeast). Closing because #199 fixed the same finding (Interpolate header key in webhook header remove buttons) and is merged. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What:
Added dynamic item context (the header key) to the
.help()and.accessibilityLabel()modifiers of the icon-only "Remove" buttons used in Webhook Headers form lists across the app (MacroEditorSheet,ActionMappingEditor,ChordMappingSheet).🎯 Why:
When iterating through a list of items (like form headers) using a
ForEachloop, having identical "Remove header" tooltips and accessibility labels for every single minus icon creates ambiguity. VoiceOver users lose track of which row they are currently focused on, making destructive actions confusing and risky.♿ Accessibility:
VoiceOver now correctly announces the specific item being targeted (e.g., "Remove Content-Type header, Button") instead of repeating the generic "Remove header" string for every item in the list.
📸 Before/After:
PR created automatically by Jules for task 12435952936888014869 started by @NSEvent
Summary by CodeRabbit