Repository navigation
Conversation
Specifically for ParseRevocationList. Upstream fixed this a different way, by patching `parseName` to be more liberal: https://go-review.googlesource.com/c/go/+/778681. However, in this repository, the cert-parsing paths don't use `parseName`, they just use `asn1.Unmarshal`. To me it seems more consistent, and a smaller change, to use `asn1.Unmarshal` for the ParseRevocation path. An alternative would be to backport the upstream `parseName` change, and also update the cert-parsing paths to use `parseName` (as they do in upstream). However, that appears to break tests with regards to some of the permissiveness properties that are the point of this package. I came across this while adding MTC support to Boulder, and it's on the blocking path for us.
zakird
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically for ParseRevocationList.
An example of a non-string type in Issuer is the
id-rdna-trustAnchorID(aRELATIVE-OID) used in MTCs:https://ietf-plants-wg.github.io/merkle-tree-certs/draft-ietf-plants-merkle-tree-certs.html#name-representing-certification-
https://datatracker.ietf.org/doc/html/draft-ietf-tls-trust-anchor-ids-07#section-4.1
Upstream fixed this a different way, by patching
parseNameto be more liberal: https://go-review.googlesource.com/c/go/+/778681.However, in this repository, the cert-parsing paths don't use
parseName, they just useasn1.Unmarshal, which accepts these attribute types just fine. To me it seems more consistent, and a smaller change, to useasn1.Unmarshalfor the ParseRevocation path.An alternative would be to backport the upstream
parseNamechange, and also update the cert-parsing paths to useparseName(as they do in upstream). However, that appears to break tests with regards to some of the permissiveness properties that are the point of this package.I came across this while adding MTC support to Boulder, and it's on the blocking path for us.