Repository navigation
feat: per-request transport options - #1
Merged
Merged
Conversation
Transport::send() now takes a TransportOptions argument, so timeouts set by middleware or by a request reach the transport instead of being dropped at the PSR-7 boundary. BREAKING CHANGE: Transport::send() requires a second TransportOptions argument. Custom transports and test doubles must accept it. See UPGRADE-1.0.md.
Extract the request-level options step into its own middleware so HttpClient no longer imports a class from its own namespace.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transport::send()now takes aTransportOptionsargument, so timeouts set by middleware or by a request reach the transport instead of being dropped at the PSR-7 boundary.WithTimeout(factory),TimeoutMiddleware(pipeline), orHasTransportOptions(per endpoint). Precedence is request > client > global default;nullnever overwrites a value set earlier.GuzzleTransport, which maps the options and throwsTransportTimeoutExceptionon a cURL timeout.Psr18Transportignores them, since PSR-18 has no per-request options.Breaking change: every custom
Transportand test double must accept the second argument. SeeUPGRADE-1.0.md. TheBREAKING CHANGEcommit footer makes semantic-release cut 1.0.0 on merge.guzzlehttp/guzzlemoves from a README suggestion to a hard dependency. A PHPStan stub cannot describe an optional class, so declaring it optional would break analysis for consumers without Guzzle installed.Test Plan
vendor/bin/phpunit— 63 tests, 133 assertions, 0 failuresvendor/bin/phpstan analyse— no errors at max levelvendor/bin/phpcs -p src— cleancomposer normalize --dry-run— already normalized