Repository navigation
Conversation
When the support team gets bugtool archives from several hosts of a pool, it is hard to know which host wrote each xha.log line. This patch adds the hostname to every line in xha.log so it is easy to see. The hostname is read once in log_initialize(), before the threads start. It is read again in log_reopen(), with the write lock held, so a new hostname appears after the log rotation. If gethostname() fails, "-" is used. Co-developed-by: Andrii Sultanov <andriy.sultanov@vates.tech> Signed-off-by: Guillaume Thouvenin <guillaume.thouvenin@vates.tech>
Author
|
Here is what it looks like now: |
Author
|
I will reopen it from xcp-ng fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the support team gets bugtool archives from several hosts of a pool, it is hard to know which host wrote each xha.log line. This patch adds the hostname to every line in xha.log so it is easy to see.
The hostname is read once in log_initialize(), before the threads start. It is read again in log_reopen(), with the write lock held, so a new hostname appears after the log rotation. If gethostname() fails, "-" is used.
Co-developed-by: Andrii Sultanov andriy.sultanov@vates.tech