Skip to content

Fixing cloud console for Moesif Insights plugin wiring. - #3432

Merged
AnuGayan merged 1 commit into
wso2:mainfrom
Milanka00:feature/cloud-moesif-insights
Sep 14, 2026
Merged

AnuGayan merged 1 commit into
wso2:mainfrom
Milanka00:feature/cloud-moesif-insights

Conversation

@Milanka00

Copy link
Copy Markdown
Contributor

Purpose

  • Build fix: remove conflicting Window augmentation from the insights package so tsc --noEmit passes when plugins are wired as file: deps in the cloud console Docker build; harden runtimeFlags window reads accordingly.

Goals

Describe what solutions this feature or fix introduces to address the problems outlined above.

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI. Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fb29c8a7-a047-4bbe-8977-cf4adbc975a4

📥 Commits

Reviewing files that changed from the base of the PR and between e77cb25 and 9e21773.

📒 Files selected for processing (4)
  • portals/cloud-plugins/apip-cloud-ui-insights/src/InsightsEmbed.unconfigured.test.tsx
  • portals/cloud-plugins/apip-cloud-ui-insights/src/config/runtimeConfig.test.ts
  • portals/cloud-plugins/apip-cloud-ui-insights/src/config/vite-env.d.ts
  • portals/cloud-plugins/apip-cloud-ui/src/runtimeFlags.ts
💤 Files with no reviewable changes (1)
  • portals/cloud-plugins/apip-cloud-ui-insights/src/config/vite-env.d.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Runtime configuration handling

Layer / File(s) Summary
Runtime flag resolution
portals/cloud-plugins/apip-cloud-ui/src/runtimeFlags.ts
readRuntimeBoolean returns false when window is unavailable and reads from __RUNTIME_CONFIG__ or config as a single selected object.
Runtime window typing and test setup
portals/cloud-plugins/apip-cloud-ui-insights/src/config/vite-env.d.ts, portals/cloud-plugins/apip-cloud-ui-insights/src/*test*
The global Window augmentation was removed. Tests define local window types and use them for runtime configuration cleanup and assignments.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9e217

The runtime flag and Insights typing changes preserve the established configuration contracts, so this change is mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The Purpose section explains the build issue and intended fix, but the remaining required sections contain only template placeholders. Complete the Approach, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment sections. Include test coverage and environment details, mark documentation impact as N/A with an explanation …
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing cloud console wiring for the Moesif Insights plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Complete the Approach, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment sections. Include test coverage and environment details, mark documentation impact as N/A with an explanation if applicable, and provide the required security check answers.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@AnuGayan
AnuGayan merged commit 2aba253 into wso2:main Sep 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants