Stop scanning wp-cli/wp-cli.github.com for contributors and release notes - #74
Conversation
…otes The website repository is no longer maintained, so it never has an open milestone to read from. Both bundle-wide code paths skipped it harmlessly at runtime, but it still cost an API call per invocation and implied the repo was part of a release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xw2XwqE3C4cGGZ6EbS8p3V
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe default repository lists for bundle contributor collection and bundle release notes no longer include ChangesBundle repository list updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the retired wp-cli/wp-cli.github.com repository from the hardcoded “bundle-wide” repository lists used by the maintenance contrib-list and release-notes commands, avoiding an unnecessary GitHub API call and preventing the repo from being implied as part of a release.
Changes:
- Removed
wp-cli/wp-cli.github.comfrom the default repo list in.maintenance/src/Contrib_List_Command.php. - Removed
wp-cli/wp-cli.github.comfrom the bundle repo list iterated by.maintenance/src/Release_Notes_Command.php.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.maintenance/src/Release_Notes_Command.php |
Stops iterating over the retired repo when gathering bundle release notes. |
.maintenance/src/Contrib_List_Command.php |
Stops including the retired repo in the default bundle repo set for contributor listing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The website repository is no longer maintained, so it never has an open milestone to read from. It is still hardcoded into the bundle-wide repository list in two places:
.maintenance/src/Contrib_List_Command.php— the list used whencontrib-listis invoked with no repo argument.maintenance/src/Release_Notes_Command.php— the same list inget_bundle_release_notes()Both paths already tolerated it at runtime (
contrib-listhitsif ( ! $milestone ) { continue; }, andrelease-notesreduces over an empty milestone set), so this is not a bug fix — it removes a wasted API call per invocation and stops implying the repo is part of a release.Both commands are on the critical path of the release automation being added in wp-cli/wp-cli#6352, which calls them to generate the changelog and contributor list.
Testing
php -lpasses on both files. The change removes one array element from each list and touches nothing else; no callers pass these lists in, and neither list is exposed outside its own method.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xw2XwqE3C4cGGZ6EbS8p3V
Generated by Claude Code
Summary by CodeRabbit
wp-cli/wp-cli.github.comrepository.