Skip to content

Revert "feat: temporarily disable the Background effects regardless of backend [WPB-26420]" #21757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zskhan merged 1 commit into from
Jul 7, 2026
Merged

Revert "feat: temporarily disable the Background effects regardless of backend [WPB-26420]" #21757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/webapp/src/script/repositories/media/backgroundEffectsHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ describe('BackgroundEffectsHandler', () => {
expect(preferredEffectWrites).toHaveLength(0);
});

it('keeps feature disabled when background effects feature is enabled', () => {
it('enables feature when background effects feature is enabled', () => {
const features: Partial<FeatureList> = {
backgroundEffects: {
status: FEATURE_STATUS.ENABLED,
Expand All @@ -411,11 +411,11 @@ describe('BackgroundEffectsHandler', () => {

new BackgroundEffectsHandler(mockController, teamState);

expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(false);
expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(true);
expect(backgroundEffectsStore.getState().isPerformancePanelEnabled).toBe(false);
});

it('keeps feature disabled from TeamState even when storage flag is false', () => {
it('enables feature from TeamState even when storage flag is false', () => {
mockStorage.getItem.mockImplementation((key: string) => {
if (key === VIDEO_BACKGROUND_EFFECTS_FEATURE_STORAGE_KEY) {
return 'false';
Expand All @@ -433,7 +433,7 @@ describe('BackgroundEffectsHandler', () => {

new BackgroundEffectsHandler(mockController, teamState);

expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(false);
expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(true);
expect(backgroundEffectsStore.getState().isPerformancePanelEnabled).toBe(false);
});

Expand Down Expand Up @@ -469,7 +469,7 @@ describe('BackgroundEffectsHandler', () => {
expect(backgroundEffectsStore.getState().isPerformancePanelEnabled).toBe(false);
});

it('keeps feature disabled when TeamState background effects feature changes', () => {
it('updates feature enabled state when TeamState background effects feature changes', () => {
teamState.teamFeatures(undefined);

new BackgroundEffectsHandler(mockController, teamState);
Expand All @@ -485,7 +485,7 @@ describe('BackgroundEffectsHandler', () => {

teamState.teamFeatures(features);

expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(false);
expect(backgroundEffectsStore.getState().isFeatureEnabled).toBe(true);
expect(backgroundEffectsStore.getState().isPerformancePanelEnabled).toBe(false);
});
});
6 changes: 3 additions & 3 deletions apps/webapp/src/script/repositories/team/TeamState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ export class TeamState {
() => this.teamFeatures()?.conferenceCalling?.status === FEATURE_STATUS.ENABLED,
);

// Temporarily disable the Background effects regardless of backend state.
// This will be reverted after 6th of July 2026
this.isBackgroundEffectsEnabled = ko.pureComputed(() => false);
this.isBackgroundEffectsEnabled = ko.pureComputed(() => {
return this.teamFeatures()?.backgroundEffects?.status === FEATURE_STATUS.ENABLED;
});

this.isGuestLinkEnabled = ko.pureComputed(
() => this.teamFeatures()?.conversationGuestLinks?.status === FEATURE_STATUS.ENABLED,
Expand Down
Loading