Skip to content

WPB-29054: use minio mirror for fake-aws-s3 #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwille wants to merge 9 commits into
base: master
Choose a base branch
from
Open

WPB-29054: use minio mirror for fake-aws-s3 #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae7014e
WPB-29054: use minio mirror for fake-aws-s3
lwille Oct 8, 2026
9f6ec3e
WPB-29054: use minio mirror for fake-aws-s3
lwille Oct 8, 2026
a1b4b86
lint: add newline at end of file
lwille Oct 8, 2026
c8cb4fe
lint: newline
lwille Oct 8, 2026
696d596
fix: block fake-aws-s3 from default-build
lwille Oct 8, 2026
260ab44
Fix changelog message
lwille Oct 8, 2026
c97ab2c
REMOVEME: not sure why values weren't picked up previously, try somet…
lwille Oct 8, 2026
a3d0ff8
remove ineffective values
lwille Oct 8, 2026
2cc48e5
Apply suggestion from @lwille
lwille Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5-bug-fixes/fix-minio-image
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed: use mirror for fetching unavailable Minio images
2 changes: 1 addition & 1 deletion offline/default-build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ TASKS_DIR="${SCRIPT_DIR}/../tasks"
# --------------------------

# pulling the charts based on builds.json, charts to be skipped are passed as arguments HELM_CHART_EXCLUDE_LIST
"${TASKS_DIR}"/proc_pull_charts.sh OUTPUT_DIR="${OUTPUT_DIR}" HELM_CHART_EXCLUDE_LIST="inbucket,wire-server-enterprise,postgresql,rust-sft,fluent-bit"
"${TASKS_DIR}"/proc_pull_charts.sh OUTPUT_DIR="${OUTPUT_DIR}" HELM_CHART_EXCLUDE_LIST="inbucket,wire-server-enterprise,postgresql,rust-sft,fluent-bit,fake-aws-s3"

# pulling the charts from helm-charts repo, charts to be included are passed as arguments HELM_CHART_INCLUDE_LIST
# "${TASKS_DIR}"/proc_pull_ext_charts.sh OUTPUT_DIR="${OUTPUT_DIR}" HELM_CHART_INCLUDE_LIST="postgresql-external"
Expand Down
8 changes: 8 additions & 0 deletions values/fake-aws-s3/demo-values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
enabled: true
minio:
image:
repository: quay.io/wire/mirror-images/minio/minio
tag: RELEASE.2023-07-07T07-13-57Z
mcImage:
repository: quay.io/wire/mirror-images/minio/mc
tag: RELEASE.2023-06-28T21-54-17Z
9 changes: 9 additions & 0 deletions values/fake-aws-s3/prod-values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Disable since prod should use an externally provided minio
enabled: false
minio:
image:
repository: quay.io/wire/mirror-images/minio/minio
tag: RELEASE.2023-07-07T07-13-57Z
mcImage:
repository: quay.io/wire/mirror-images/minio/mc
tag: RELEASE.2023-06-28T21-54-17Z
1 change: 0 additions & 1 deletion values/fake-aws/demo-secrets.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# Disable since prod should use an externally provided minio
fake-aws-s3:
enabled: true
minio:
Expand Down
8 changes: 7 additions & 1 deletion values/fake-aws/demo-values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Disable since prod should use an externally provided minio
fake-aws-s3:
enabled: true
Comment thread
lwille marked this conversation as resolved.
minio:
image:
repository: quay.io/wire/mirror-images/minio/minio
tag: RELEASE.2023-07-07T07-13-57Z
mcImage:
repository: quay.io/wire/mirror-images/minio/mc
tag: RELEASE.2023-06-28T21-54-17Z
7 changes: 7 additions & 0 deletions values/fake-aws/prod-values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# Disable since prod should use an externally provided minio
fake-aws-s3:
enabled: false
minio:
image:
repository: quay.io/wire/mirror-images/minio/minio
tag: RELEASE.2023-07-07T07-13-57Z
mcImage:
repository: quay.io/wire/mirror-images/minio/mc
tag: RELEASE.2023-06-28T21-54-17Z
Loading