feat(forest): node lifecycle closure, measurable flag, faster traversal - #41
Merged
Merged
Conversation
TtTRz
commented
Aug 25, 2026
TtTRz
commented
Member
- track calc handles set through the CalcHandle style setters and release them via the NodeSetFreeCalcHandle callback on drop; clear surviving children parent pointers to prevent dangling references
- replace NodeType::Text special-casing with an is_measurable capability flag for measure/baseline cache gating and dirty cache clearing; text nodes remain implicitly measurable, NodeSetMeasurable opts other node kinds in
- switch the child list from RefCell to UnsafeCell and return a borrowed slice from children(), removing per-call Vec allocation in layout traversal and dirty clearing (about 11x faster full-tree relayout on the 2000-node bench)
- track calc handles set through the CalcHandle style setters and release them via the NodeSetFreeCalcHandle callback on drop; clear surviving children parent pointers to prevent dangling references - replace NodeType::Text special-casing with an is_measurable capability flag for measure/baseline cache gating and dirty cache clearing; text nodes remain implicitly measurable, NodeSetMeasurable opts other node kinds in - switch the child list from RefCell to UnsafeCell and return a borrowed slice from children(), removing per-call Vec allocation in layout traversal and dirty clearing (about 11x faster full-tree relayout on the 2000-node bench)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.