Repository navigation
chore[test]: removed stale xfails - #5319
Open
HodanPlodky wants to merge 17 commits into
Open
HodanPlodky wants to merge 17 commits into
HodanPlodky wants to merge 17 commits into
Conversation
was not necessary The error was that the `uint256` cannot be negated which was introduced in `ddfce5273` when the iteration variable `i` was explicitaly typed to `uint256`. If the type of `i` is `int128` the typechecker can accept contract and it compiles correctly and test passes More over there was an error in the test_return_empty where the tests asserts did not compare to correct value. That was introduced in `097aecfe29e6c218d165d223f0272265cf6f5403` I a not sure if it was correct at the time but it does not seem correct now.
requested it The problem was that the test had syntax error on the first line (wrong ident) and did not really test what it was mentioned in GH issue in comment. Probably copy error way back when I checked and the contract compiled from the moment it was introduced as test (if the syntax error was fix) and on the commit before that it was an error.
`run_pass` required info about which memory is it using (abstract/concrete) so that was an error right now it errors with what the comment says
Maybe worth of full PR but the fix involves `unary` grammar rule which
was not recursive ie.
```
?unary: power
...
| "~" power -> invert
...
```
and making it recursive
```
?unary: power
...
| "~" unary -> invert
...
```
The legacy is using `UnfoldableNode` and venom codegen was using `CompilerPanic` with info that it is unfoldable node. So I just changed venom to use same exception as legacy to have just one exeption in xfail to ensure that it test what it says it test + I had to change few more places where the venom codegen expected CompilerPanic (ie in tests)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Gas ChangesNo changes detected. Summary
|
📊 Bytecode Size Changes (venom)No changes detected. Full bytecode sizes
|
HodanPlodky
marked this pull request as ready for review
October 23, 2026 13:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
harkal
reviewed
Oct 27, 2026
| @@ -51,7 +51,7 @@ def test_abi_decode_success(good_code): | |||
|
|
|||
|
|
|||
| # UnfoldableNode on legacy, CompilerPanic in venom | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| def test_round_trip_examples(path: Path, optimize, compiler_settings): |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture