Repository navigation
Fix value strip underflow - #433
Merged
Merged
Conversation
After an unquoted value ucl_parse_value strips trailing whitespace by
walking back from chunk->pos with no lower bound. When the value is empty
and starts the chunk - the parser is in a value state from the previous
chunk, say '[', and the next chunk opens with ',', ';', '}' or a NUL - the
loop reads the byte before the chunk's buffer, a one-byte overread.
Within a single chunk that byte belongs to the same buffer, so only
multi-chunk input exposes it; the outcome ('string value must not be empty')
is the same either way.
Bound the loop by the value start.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W3aXdPKAnVwjiNtZstnmPj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #432